Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254559: Remove unimplemented JVMFlag::get_locked_message_ext #598

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 12, 2020

The definition was removed with JDK-8224599, the declaration was left behind.

Testing:

  • Linux x86_64 build
  • Text search for get_locked_message_ext in entire src/

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8254559: Remove unimplemented JVMFlag::get_locked_message_ext

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/598/head:pull/598
$ git checkout pull/598

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 12, 2020
@openjdk
Copy link

openjdk bot commented Oct 12, 2020

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 12, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2020

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivially good.

Thanks,
David

@openjdk
Copy link

openjdk bot commented Oct 12, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254559: Remove unimplemented JVMFlag::get_locked_message_ext

Reviewed-by: dholmes, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 54bbe76: 8251544: CTW: C2 fails with assert(no_dead_loop) failed: dead loop detected
  • 13fe054: 8253588: C1: assert(false) failed: unknown register on x86_32 only with -XX:+TraceLinearScanLevel=4
  • 59378a1: 8254164: G1 only removes self forwarding pointers for last collection set increment
  • bf46acf: 8254028: G1 incorrectly updates scan_top for collection set regions during preparation of evacuation
  • a2bb4c6: 8254314: Shenandoah: null checks in c2 should not skip over native load barrier
  • c73a0ff: 8252105: Parallel heap inspection for ZCollectedHeap

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 12, 2020
@shipilev
Copy link
Member Author

Thanks!

/integrate

@openjdk openjdk bot closed this Oct 12, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2020
@openjdk
Copy link

openjdk bot commented Oct 12, 2020

@shipilev Since your change was applied there have been 7 commits pushed to the master branch:

  • 0ec1d63: 8253117: Replace HTML tables in javadoc summaries with CSS grid elements
  • 54bbe76: 8251544: CTW: C2 fails with assert(no_dead_loop) failed: dead loop detected
  • 13fe054: 8253588: C1: assert(false) failed: unknown register on x86_32 only with -XX:+TraceLinearScanLevel=4
  • 59378a1: 8254164: G1 only removes self forwarding pointers for last collection set increment
  • bf46acf: 8254028: G1 incorrectly updates scan_top for collection set regions during preparation of evacuation
  • a2bb4c6: 8254314: Shenandoah: null checks in c2 should not skip over native load barrier
  • c73a0ff: 8252105: Parallel heap inspection for ZCollectedHeap

Your commit was automatically rebased without conflicts.

Pushed as commit 638f910.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8224599-remove-get-locked-ext branch October 12, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants