8254560: Shenandoah: Concurrent Strong Roots logging is incorrect

[shipilev]

Look:

[1382.171s][info][gc,stats] Concurrent Strong Roots            1059 us, parallelism: 2.12x
[1382.171s][info][gc,stats] Rendezvous                         2246 us
[1382.171s][info][gc,stats]   CSR: Code Cache Roots              84 us, workers (us):  14,  17,  13,  14,  10,   6,   4,   5, 
[1382.171s][info][gc,stats]   CSR: VM Weak Roots               2162 us, workers (us): ---, ---, 905, ---, ---, 388, 383, 486, 

There should be CSR: <total>, but Rendezvous is in its place.

Testing:

• Eyeballing -Xlog:gc+stats on Linux x86_64

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8254560: Shenandoah: Concurrent Strong Roots logging is incorrect

Reviewers

• Roman Kennke (@rkennke - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/599/head:pull/599
$ git checkout pull/599

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6a0fbfd)

[rkennke]

Looks good to me! Thanks!

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254560: Shenandoah: Concurrent Strong Roots logging is incorrect

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 638f910: 8254559: Remove unimplemented JVMFlag::get_locked_message_ext
• 0ec1d63: 8253117: Replace HTML tables in javadoc summaries with CSS grid elements
• 54bbe76: 8251544: CTW: C2 fails with assert(no_dead_loop) failed: dead loop detected
• 13fe054: 8253588: C1: assert(false) failed: unknown register on x86_32 only with -XX:+TraceLinearScanLevel=4
• 59378a1: 8254164: G1 only removes self forwarding pointers for last collection set increment
• bf46acf: 8254028: G1 incorrectly updates scan_top for collection set regions during preparation of evacuation
• a2bb4c6: 8254314: Shenandoah: null checks in c2 should not skip over native load barrier
• c73a0ff: 8252105: Parallel heap inspection for ZCollectedHeap

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

/integrate

[openjdk]

@shipilev Since your change was applied there have been 8 commits pushed to the master branch:

• 638f910: 8254559: Remove unimplemented JVMFlag::get_locked_message_ext
• 0ec1d63: 8253117: Replace HTML tables in javadoc summaries with CSS grid elements
• 54bbe76: 8251544: CTW: C2 fails with assert(no_dead_loop) failed: dead loop detected
• 13fe054: 8253588: C1: assert(false) failed: unknown register on x86_32 only with -XX:+TraceLinearScanLevel=4
• 59378a1: 8254164: G1 only removes self forwarding pointers for last collection set increment
• bf46acf: 8254028: G1 incorrectly updates scan_top for collection set regions during preparation of evacuation
• a2bb4c6: 8254314: Shenandoah: null checks in c2 should not skip over native load barrier
• c73a0ff: 8252105: Parallel heap inspection for ZCollectedHeap

Your commit was automatically rebased without conflicts.

Pushed as commit 0fab73e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.