8271124: CTW tests crashed with assert(is_valid_method(o)) failed: should be valid jmethodid

[coleenp]

Add a lock in VirtualSpaceList::contains to protect the virtual space list for Metaspace::contains. See CR for more details.
Tested with tier2 linux-aarch64-debug where the failure happened, and tier1-3 linux-x64-debug,linux-x64,windows-x64-debug in progress (almost done but it's being slow today).

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271124: CTW tests crashed with assert(is_valid_method(o)) failed: should be valid jmethodid

Reviewers

• Ioi Lam (@iklam - Reviewer) ⚠️ Review applies to ea62b5c

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5990/head:pull/5990
$ git checkout pull/5990

Update a local copy of the PR:
$ git checkout pull/5990
$ git pull https://git.openjdk.java.net/jdk pull/5990/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5990

View PR using the GUI difftool:
$ git pr show -t 5990

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5990.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (cc2ae480)
• 00: Full (ea62b5ce)

[coleenp]

/label remove hotspot-runtime
/label add hotspot

[openjdk]

@coleenp
The hotspot-runtime label was successfully removed.

[openjdk]

@coleenp
The hotspot label was successfully added.

[coleenp]

Shenandoah test gets a lock inversion with the introduction of the Metaspace_lock.

[iklam]

LGTM.

I looked at the other functions in this class, and it seems like VirtualSpaceList::is_full() has a similar problem. I filed https://bugs.openjdk.java.net/browse/JDK-8275440 to remove that function.

Other functions like reserved_words(), committed_words() and num_nodes() also seem suspicious. @tstuefe can you take a look?

[coleenp]

I'm reopening for more comments. Shenandoah gets:

 assert(false) failed: Attempting to acquire lock Metaspace_lock/nosafepoint-3 out of order with lock StackWatermark_lock/stackwatermark -- possible deadlock

found via github actions.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271124: CTW tests crashed with assert(is_valid_method(o)) failed: should be valid jmethodid

Reviewed-by: iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Reclosing this PR.

[tstuefe]

LGTM.

I looked at the other functions in this class, and it seems like VirtualSpaceList::is_full() has a similar problem. I filed https://bugs.openjdk.java.net/browse/JDK-8275440 to remove that function.

Other functions like reserved_words(), committed_words() and num_nodes() also seem suspicious. @tstuefe can you take a look?

I'll take a look.