Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8275436 [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect #5994

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Oct 18, 2021

This reverts commit 3150069.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275436: [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5994/head:pull/5994
$ git checkout pull/5994

Update a local copy of the PR:
$ git checkout pull/5994
$ git pull https://git.openjdk.java.net/jdk pull/5994/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5994

View PR using the GUI difftool:
$ git pr show -t 5994

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5994.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 18, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Oct 18, 2021

/label add hotspot-runtime
/label add hotspot-jfr
/label add serviceability

@openjdk openjdk bot added the hotspot-runtime label Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Oct 18, 2021
@openjdk openjdk bot added the hotspot-jfr label Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@dcubed-ojdk
The hotspot-jfr label was successfully added.

@openjdk openjdk bot added rfr serviceability labels Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@dcubed-ojdk
The serviceability label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 18, 2021

Webrevs

Copy link

@mgronlun mgronlun left a comment

Thanks for creating the backout Dan, looks good.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Oct 18, 2021

@mgronlun - Thanks for the fast review!

@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275436: [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • bad75e6: 8275150: URLClassLoaderTable should store OopHandle instead of Handle

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 18, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Oct 18, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

Going to push as commit a03119c.
Since your change was applied there has been 1 commit pushed to the master branch:

  • bad75e6: 8275150: URLClassLoaderTable should store OopHandle instead of Handle

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@dcubed-ojdk Pushed as commit a03119c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8275436 branch Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-runtime integrated serviceability
2 participants