Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261455: Automatically generate the CDS archive if necessary #5997

Closed
wants to merge 8 commits into from

Conversation

yminqi
Copy link
Contributor

@yminqi yminqi commented Oct 18, 2021

Please review,
When shared archive (dynamic archive) failed to map due to damage of the archive file, dump/run jdk version mismatch or non-existence file etc, the new patch will automatically create a new shared archive if -XX:+AutoCreateSharedArchive specified with the name based on SharedArchiveFile.
This is a revised patch based on the old PR: 5077 and after bug 8273152 integrated.

Tests: tier1,tier2,tier3,tier4

Thanks
Yumin


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261455: Automatically generate the CDS archive if necessary

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5997/head:pull/5997
$ git checkout pull/5997

Update a local copy of the PR:
$ git checkout pull/5997
$ git pull https://git.openjdk.java.net/jdk pull/5997/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5997

View PR using the GUI difftool:
$ git pr show -t 5997

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5997.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 18, 2021

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@yminqi The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Oct 18, 2021
@yminqi
Copy link
Contributor Author

@yminqi yminqi commented Oct 18, 2021

/label remove hotspot
/label add hotspot-runtime

@openjdk openjdk bot removed the hotspot label Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@yminqi
The hotspot label was successfully removed.

@openjdk openjdk bot added the hotspot-runtime label Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@yminqi
The hotspot-runtime label was successfully added.

@yminqi yminqi marked this pull request as ready for review Oct 18, 2021
@openjdk openjdk bot added the rfr label Oct 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 18, 2021

Copy link
Member

@iklam iklam left a comment

Tiis overall looks good! I have a few questions and suggestions.

src/hotspot/share/cds/filemap.cpp Show resolved Hide resolved
src/hotspot/share/runtime/thread.cpp Outdated Show resolved Hide resolved
src/hotspot/share/cds/filemap.cpp Show resolved Hide resolved
// 10.3 run with the created dynamic archive with -XX:+AutoCreateSharedArchive should pass
print("10.3 run with the created dynamic archive with -XX:+AutoCreateSharedArchive should pass");
run(TOP_NAME,
Copy link
Member

@calvinccheung calvinccheung Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a check to make sure the dynamic archive hasn't been changed after run?

Copy link
Member

@calvinccheung calvinccheung left a comment

Looks good overall. Just a few minor comments.

@yminqi
Copy link
Contributor Author

@yminqi yminqi commented Nov 5, 2021

I will be out of work for a while so close this PR. @iklam will resume the work and send new PR for this.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime rfr
3 participants