8261455: Automatically generate the CDS archive if necessary #5997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/label remove hotspot |
|
@yminqi |
|
@yminqi |
Webrevs
|
iklam
suggested changes
Oct 19, 2021
test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchive.java
Outdated
Show resolved
Hide resolved
…ned up some check code
calvinccheung
reviewed
Oct 22, 2021
calvinccheung
reviewed
Oct 22, 2021
| // 10.3 run with the created dynamic archive with -XX:+AutoCreateSharedArchive should pass | ||
| print("10.3 run with the created dynamic archive with -XX:+AutoCreateSharedArchive should pass"); | ||
| run(TOP_NAME, |
There was a problem hiding this comment.
Maybe add a check to make sure the dynamic archive hasn't been changed after run?
calvinccheung
reviewed
Oct 22, 2021
test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchive.java
Outdated
Show resolved
Hide resolved
calvinccheung
reviewed
Oct 22, 2021
test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchive.java
Outdated
Show resolved
Hide resolved
added 5 commits
Oct 23, 2021
|
I will be out of work for a while so close this PR. @iklam will resume the work and send new PR for this. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Please review,
When shared archive (dynamic archive) failed to map due to damage of the archive file, dump/run jdk version mismatch or non-existence file etc, the new patch will automatically create a new shared archive if -XX:+AutoCreateSharedArchive specified with the name based on SharedArchiveFile.
This is a revised patch based on the old PR: 5077 and after bug 8273152 integrated.
Tests: tier1,tier2,tier3,tier4
Thanks
Yumin
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5997/head:pull/5997$ git checkout pull/5997Update a local copy of the PR:
$ git checkout pull/5997$ git pull https://git.openjdk.java.net/jdk pull/5997/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 5997View PR using the GUI difftool:
$ git pr show -t 5997Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5997.diff