Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275445: RunThese30M.java failed "assert(ZAddress::is_marked(addr)) failed: Should be marked" #6001

Closed
wants to merge 2 commits into from

Conversation

mgronlun
Copy link

@mgronlun mgronlun commented Oct 19, 2021

Greetings,

This fixes the issue seen in testing when accessing an oop as part of unloading (introduced with JDK-8266936).

Instead, oop accesses will be done outside of unloading and the result, i.e the codesource attribute, will be cached and reused in the FinalizerEntry.

Testing: tier1-3, jdk_jfr

Thanks
Markus

PS one effect of this is that classes that unload before they have allocated anything will not have a codesource attribute. This can be fixed by letting classes register with the table as part of class loading, instead of during allocation. I will follow-up with a separate change for that.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275445: RunThese30M.java failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6001/head:pull/6001
$ git checkout pull/6001

Update a local copy of the PR:
$ git checkout pull/6001
$ git pull https://git.openjdk.java.net/jdk pull/6001/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6001

View PR using the GUI difftool:
$ git pr show -t 6001

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6001.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 19, 2021

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@mgronlun The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Oct 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 19, 2021

Webrevs

@mgronlun
Copy link
Author

@mgronlun mgronlun commented Oct 19, 2021

/label remove hotspot

@openjdk openjdk bot removed the hotspot label Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@mgronlun
The hotspot label was successfully removed.

@mgronlun
Copy link
Author

@mgronlun mgronlun commented Oct 19, 2021

/label add hotspot-jfr hotspot-runtime serviceability

@openjdk openjdk bot added hotspot-jfr hotspot-runtime serviceability labels Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@mgronlun
The hotspot-jfr label was successfully added.

The hotspot-runtime label was successfully added.

The serviceability label was successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275445: RunThese30M.java failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"

Reviewed-by: egahlin, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • dcd6e0d: 8255724: [XRender] the BlitRotateClippedArea test fails on Linux in the XR pipeline
  • d17d81a: 8273626: G1: Factor out concurrent segmented array from G1CardSetAllocator
  • a4491f2: 8275413: Remove unused InstanceKlass::set_array_klasses() method
  • 9d191fc: 8245095: Implementation of JEP 408: Simple Web Server

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 19, 2021
Copy link
Contributor

@coleenp coleenp left a comment

Looks good Markus.

@mgronlun
Copy link
Author

@mgronlun mgronlun commented Oct 19, 2021

Thanks, @egahlin and @coleenp, for your quick reviews. I will proceed to integrate this to restore testing in the CI.

@mgronlun
Copy link
Author

@mgronlun mgronlun commented Oct 19, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

Going to push as commit 98ab4b0.
Since your change was applied there have been 4 commits pushed to the master branch:

  • dcd6e0d: 8255724: [XRender] the BlitRotateClippedArea test fails on Linux in the XR pipeline
  • d17d81a: 8273626: G1: Factor out concurrent segmented array from G1CardSetAllocator
  • a4491f2: 8275413: Remove unused InstanceKlass::set_array_klasses() method
  • 9d191fc: 8245095: Implementation of JEP 408: Simple Web Server

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@mgronlun Pushed as commit 98ab4b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-runtime integrated serviceability
3 participants