Skip to content

8233724: Remove -Wc++14-compat warning suppression in operator_new.cpp #6005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Oct 19, 2021

Please review this small change to remove the unneeded 'PRAGMA_DISABLE_GCC_WARNING("-Wc++14-compat")' from operator_new.cpp. The change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows.

Thanks, Harold


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8233724: Remove -Wc++14-compat warning suppression in operator_new.cpp

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6005/head:pull/6005
$ git checkout pull/6005

Update a local copy of the PR:
$ git checkout pull/6005
$ git pull https://git.openjdk.java.net/jdk pull/6005/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6005

View PR using the GUI difftool:
$ git pr show -t 6005

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6005.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2021
@openjdk
Copy link

openjdk bot commented Oct 19, 2021

@hseigel The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 19, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2021

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems trivial!

@openjdk
Copy link

openjdk bot commented Oct 19, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8233724: Remove -Wc++14-compat warning suppression in operator_new.cpp

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • a579483: 8274899: Replace usages of Collections.sort with List.sort call in jdk.hotspot.agent
  • 002c538: 8275287: Relax memory ordering constraints on updating instance class and array class counters
  • 98ab4b0: 8275445: RunThese30M.java failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"
  • dcd6e0d: 8255724: [XRender] the BlitRotateClippedArea test fails on Linux in the XR pipeline
  • d17d81a: 8273626: G1: Factor out concurrent segmented array from G1CardSetAllocator

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2021
@hseigel
Copy link
Member Author

hseigel commented Oct 20, 2021

Thanks Coleen!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 20, 2021

Going to push as commit a91a0a5.
Since your change was applied there have been 48 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2021
@openjdk
Copy link

openjdk bot commented Oct 20, 2021

@hseigel Pushed as commit a91a0a5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants