Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268595: java/io/Serializable/serialFilter/GlobalFilterTest.java#id1 failed in timeout #6008

Closed
wants to merge 1 commit into from

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Oct 19, 2021

The GlobalFilterTest has to 2 @test tags. One of them has failed with a timeout as noted in https://bugs.openjdk.java.net/browse/JDK-8268595. The timeout seems to have happened even after the tests had already completed successfully. Like I note in the JBS comments of that issue, I suspect it might have to do with the "-XX:StartFlightRecording:name=DeserializationEvent,dumponexit=true" usage in this test action.

The commit in this PR removes that second @test altogether because (correct me if I'm wrong) from what I understand, this test never enables the DeserializationEvent which means there is no JFR events being captured for deserialization in this test, nor does the test do any JFR events related testing. So, I think this second @test is virtually a no-op when it comes to the JFR testing. There's a separate TestDeserializationEvent which has a comprehensive testing of the DeserializationEvent.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268595: java/io/Serializable/serialFilter/GlobalFilterTest.java#id1 failed in timeout

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6008/head:pull/6008
$ git checkout pull/6008

Update a local copy of the PR:
$ git checkout pull/6008
$ git pull https://git.openjdk.java.net/jdk pull/6008/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6008

View PR using the GUI difftool:
$ git pr show -t 6008

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6008.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2021

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2021
@openjdk
Copy link

openjdk bot commented Oct 19, 2021

@jaikiran The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 19, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2021

Webrevs

@RogerRiggs
Copy link
Contributor

RogerRiggs commented Oct 20, 2021

@ChrisHegarty Please comment on this change. The purpose of the second test group is not clear.
Thanks

@jaikiran
Copy link
Member Author

Roger, I think you meant to mention @ChrisHegarty and not chegar?

@RogerRiggs
Copy link
Contributor

Yes, I meant @ChrisHegarty. tnx.

@ChrisHegarty
Copy link
Member

I agree that the second @test is not all that useful, and can probably be just removed. If I remember correctly, I added the second @test during development of the feature before the more comprehensive test was added, and also when experimenting with the event being enabled by default, but it is not adding much value now.

@openjdk
Copy link

openjdk bot commented Oct 23, 2021

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268595: java/io/Serializable/serialFilter/GlobalFilterTest.java#id1 failed in timeout

Reviewed-by: chegar, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 95 new commits pushed to the master branch:

  • 7f94302: 8275511: G1: Rename needs_remset_update to remset_is_tracked in G1HeapRegionAttr
  • 0bcc174: 8275717: Reimplement STATIC_ASSERT to use static_assert
  • f623298: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
  • 1da5e6b: 8275104: IR framework does not handle client VM builds correctly
  • 5dab76b: 8275381: G1: refactor 2 constructors of G1CardSetConfiguration
  • 5bbe4ca: 8275293: A change done with JDK-8268764 mismatches the java.rmi.server.ObjID.hashCode spec
  • c94dc2a: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
  • fec470f: 8272163: Add -version option to keytool and jarsigner
  • 6523c55: 8198336: java/awt/FontMetrics/FontCrash.java fails in headless mode
  • 88bbf3c: 8273111: Default timezone should return zone ID if /etc/localtime is valid but not canonicalization on linux
  • ... and 85 more: https://git.openjdk.java.net/jdk/compare/dcd6e0da245338de68d9dede451e233f4bfaa934...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 23, 2021
@jaikiran
Copy link
Member Author

Thank you for the review Chris.

Roger, should I go ahead with the merge?

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaikiran
Copy link
Member Author

Thank you Roger.

@jaikiran
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2021

Going to push as commit f143d2a.
Since your change was applied there have been 95 commits pushed to the master branch:

  • 7f94302: 8275511: G1: Rename needs_remset_update to remset_is_tracked in G1HeapRegionAttr
  • 0bcc174: 8275717: Reimplement STATIC_ASSERT to use static_assert
  • f623298: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
  • 1da5e6b: 8275104: IR framework does not handle client VM builds correctly
  • 5dab76b: 8275381: G1: refactor 2 constructors of G1CardSetConfiguration
  • 5bbe4ca: 8275293: A change done with JDK-8268764 mismatches the java.rmi.server.ObjID.hashCode spec
  • c94dc2a: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
  • fec470f: 8272163: Add -version option to keytool and jarsigner
  • 6523c55: 8198336: java/awt/FontMetrics/FontCrash.java fails in headless mode
  • 88bbf3c: 8273111: Default timezone should return zone ID if /etc/localtime is valid but not canonicalization on linux
  • ... and 85 more: https://git.openjdk.java.net/jdk/compare/dcd6e0da245338de68d9dede451e233f4bfaa934...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2021
@openjdk
Copy link

openjdk bot commented Oct 25, 2021

@jaikiran Pushed as commit f143d2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants