Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275512: Upgrade required version of jtreg to 6.1 #6012

Closed
wants to merge 2 commits into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Oct 19, 2021

As a follow up of JEP 411, we will soon disallow security manager by default. jtreg 6.1 does not set its own security manager if JDK version is >= 18.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275512: Upgrade required version of jtreg to 6.1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6012/head:pull/6012
$ git checkout pull/6012

Update a local copy of the PR:
$ git checkout pull/6012
$ git pull https://git.openjdk.java.net/jdk pull/6012/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6012

View PR using the GUI difftool:
$ git pr show -t 6012

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6012.diff

8275512: Upgrade required version of jtreg to 6.1
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 19, 2021

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@wangweij The following labels will be automatically applied to this pull request:

  • build
  • compiler
  • core-libs
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot build core-libs compiler labels Oct 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 19, 2021

Webrevs

Copy link
Member

@magicus magicus left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275512: Upgrade required version of jtreg to 6.1

Reviewed-by: ihse, iignatyev, joehw, lancea, jjg, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 19, 2021
Copy link
Member

@iignatev iignatev left a comment

LGTM

only in patch2:
unchanged:
@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Oct 19, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

Going to push as commit c24fb85.
Since your change was applied there have been 63 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@wangweij Pushed as commit c24fb85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8275512 branch Oct 19, 2021
@xiangzhai
Copy link
Member

@xiangzhai xiangzhai commented Oct 20, 2021

Hi @wangweij

But how to be suitable for jtreg version 6-dev+0?

Running tests using JTREG control variable 'VM_OPTIONS=-XX:+UseZGC;TIMEOUT_FACTOR=20;VERBOSE=summary'
Test selection 'tier1', will run:
* jtreg:test/hotspot/jtreg:tier1
* jtreg:test/jdk:tier1
* jtreg:test/langtools:tier1
* jtreg:test/jaxp:tier1
* jtreg:test/lib-test:tier1

Running test 'jtreg:test/hotspot/jtreg:tier1'
Error: The testsuite at /var/lib/jenkins/repos/openjdk/jdk/test/hotspot/jtreg requires jtreg version 6.1 b1 or higher and this is jtreg version 6-dev+0.

Thanks,
Leslie Zhai

@magicus
Copy link
Member

@magicus magicus commented Oct 20, 2021

@xiangzhai The entire point of this PR is to not allow jtreg 6.0. You need to upgrade your local jtreg installation to 6.1.

@djelinski
Copy link
Member

@djelinski djelinski commented Oct 23, 2021

requires jtreg version 6.1 b1 or higher

This confused me a bit too; I was using jtreg-6+1.tar.gz from Adoption Group build, and apparently 6+1 is 6.0b1, not 6.1. For now I'm using jtregtip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build compiler core-libs hotspot integrated
9 participants