8275511: G1: Rename needs_remset_update to remset_is_tracked in G1HeapRegionAttr

[albertnetymk]

Simple renaming of G1HeapRegionAttr::_needs_remset_update and methods/variables involved in the call chain.

Test: build

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8275511: G1: Rename needs_remset_update to remset_is_tracked in G1HeapRegionAttr

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Stefan Johansson (@kstefanj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6013/head:pull/6013
$ git checkout pull/6013

Update a local copy of the PR:
$ git checkout pull/6013
$ git pull https://git.openjdk.java.net/jdk pull/6013/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6013

View PR using the GUI difftool:
$ git pr show -t 6013

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6013.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (b8bd4304)
• 00: Full (53b86c84)

[tschatzl]

Please also rename G1CollectedHeap::verify_region_attr_remset_update to G1CollectedHeap::verify_region_attr_remset_is_tracked.

[tschatzl]

Lgtm.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275511: G1: Rename needs_remset_update to remset_is_tracked in G1HeapRegionAttr

Reviewed-by: tschatzl, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 94 new commits pushed to the master branch:

• 0bcc174: 8275717: Reimplement STATIC_ASSERT to use static_assert
• f623298: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
• 1da5e6b: 8275104: IR framework does not handle client VM builds correctly
• 5dab76b: 8275381: G1: refactor 2 constructors of G1CardSetConfiguration
• 5bbe4ca: 8275293: A change done with JDK-8268764 mismatches the java.rmi.server.ObjID.hashCode spec
• c94dc2a: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
• fec470f: 8272163: Add -version option to keytool and jarsigner
• 6523c55: 8198336: java/awt/FontMetrics/FontCrash.java fails in headless mode
• 88bbf3c: 8273111: Default timezone should return zone ID if /etc/localtime is valid but not canonicalization on linux
• 4dec8fc: 8275645: [JVMCI] avoid unaligned volatile reads on AArch64
• ... and 84 more: https://git.openjdk.java.net/jdk/compare/dcd6e0da245338de68d9dede451e233f4bfaa934...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kstefanj]

Looks good.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 7f94302.
Since your change was applied there have been 94 commits pushed to the master branch:

• 0bcc174: 8275717: Reimplement STATIC_ASSERT to use static_assert
• f623298: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
• 1da5e6b: 8275104: IR framework does not handle client VM builds correctly
• 5dab76b: 8275381: G1: refactor 2 constructors of G1CardSetConfiguration
• 5bbe4ca: 8275293: A change done with JDK-8268764 mismatches the java.rmi.server.ObjID.hashCode spec
• c94dc2a: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
• fec470f: 8272163: Add -version option to keytool and jarsigner
• 6523c55: 8198336: java/awt/FontMetrics/FontCrash.java fails in headless mode
• 88bbf3c: 8273111: Default timezone should return zone ID if /etc/localtime is valid but not canonicalization on linux
• 4dec8fc: 8275645: [JVMCI] avoid unaligned volatile reads on AArch64
• ... and 84 more: https://git.openjdk.java.net/jdk/compare/dcd6e0da245338de68d9dede451e233f4bfaa934...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 7f94302.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.