Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274160: java/awt/Window/ShapedAndTranslucentWindows/Common.java delay is too high #6014

Closed
wants to merge 1 commit into from

Conversation

@azvegint
Copy link
Member

@azvegint azvegint commented Oct 19, 2021

Along with JDK-8210776 fix, a typo was introduced.

This fix reverts it back.

Multiple test runs showed no failures.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274160: java/awt/Window/ShapedAndTranslucentWindows/Common.java delay is too high

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6014/head:pull/6014
$ git checkout pull/6014

Update a local copy of the PR:
$ git checkout pull/6014
$ git pull https://git.openjdk.java.net/jdk pull/6014/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6014

View PR using the GUI difftool:
$ git pr show -t 6014

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6014.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 19, 2021

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title 8274160: java/awt/Window/ShapedAndTranslucentWindows/Common.java delay is too high 8274160: java/awt/Window/ShapedAndTranslucentWindows/Common.java delay is too high Oct 19, 2021
@openjdk openjdk bot added the rfr label Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the client label Oct 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 19, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274160: java/awt/Window/ShapedAndTranslucentWindows/Common.java delay is too high

Reviewed-by: psadhukhan, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 002c538: 8275287: Relax memory ordering constraints on updating instance class and array class counters

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 19, 2021
@azvegint
Copy link
Member Author

@azvegint azvegint commented Oct 19, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

Going to push as commit 895e2bd.
Since your change was applied there have been 5 commits pushed to the master branch:

  • fd10f19: 8275302: unexpected compiler error: cast, intersection types and sealed
  • 99bf7dd: 8275517: Off-by-one error in allocation
  • 8a3e0a1: 7008363: TEST_BUG: test/java/lang/StringCoding/CheckEncodings.sh does nothing and is very slow at that
  • a579483: 8274899: Replace usages of Collections.sort with List.sort call in jdk.hotspot.agent
  • 002c538: 8275287: Relax memory ordering constraints on updating instance class and array class counters

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Oct 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@azvegint Pushed as commit 895e2bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants