Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8230130: javadoc search result dialog shows cut off headers for long results #6016

Closed
wants to merge 1 commit into from

Conversation

hns
Copy link
Member

@hns hns commented Oct 19, 2021

Please review a simple fix for a rendering bug in the javadoc search result list. For very long items in that list that do not fit into the menu and require horizontal scrolling the colored selection bar used to be cut off. With this change, the selection bar covers at least the length of the item itself, or the width of the menu, whichever is bigger.

Example output: http://cr.openjdk.java.net/~hannesw/8230130/api.00/

(Search for "XMLEventFactory.createStartElement" as suggested in the bug report and then scroll horizontally.)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8230130: javadoc search result dialog shows cut off headers for long results

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6016/head:pull/6016
$ git checkout pull/6016

Update a local copy of the PR:
$ git checkout pull/6016
$ git pull https://git.openjdk.java.net/jdk pull/6016/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6016

View PR using the GUI difftool:
$ git pr show -t 6016

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6016.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2021

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2021
@openjdk
Copy link

openjdk bot commented Oct 19, 2021

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Oct 19, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2021

Webrevs

Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Nice!

@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8230130: javadoc search result dialog shows cut off headers for long results

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 300 new commits pushed to the master branch:

  • 93692ea: 8274395: Use enhanced-for instead of plain 'for' in jdk.internal.jvmstat
  • e35abe3: 8256208: Javadoc's generated overview does not show classes of unnamed package
  • f65db88: 8276841: Add support for Visual Studio 2022
  • c27afb3: 8276863: Remove test/jdk/sun/security/ec/ECDSAJavaVerify.java
  • e198594: 8250678: ModuleDescriptor.Version parsing treats empty segments inconsistently
  • 4bd5bfd: 8276731: Metaspace chunks are uncommitted twice
  • 5c7f77c: 8276850: Remove outdated comment in HeapRegionManager::par_iterate
  • 945f408: 8276098: Do precise BOT updates in G1 evacuation phase
  • 8747882: 8276790: Rename GenericCDSFileMapHeader::_base_archive_path_offset
  • 38e6d5d: 8276677: Malformed Javadoc inline tags in JDK source in javax/net/ssl
  • ... and 290 more: https://git.openjdk.java.net/jdk/compare/98ab4b03b311dcd8374cbbb21a898298798750d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 9, 2021
@hns
Copy link
Member Author

hns commented Nov 9, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 9, 2021

Going to push as commit f9024d0.
Since your change was applied there have been 304 commits pushed to the master branch:

  • 055de6f: 8223358: Incorrect HTML structure in annotation pages
  • a60e912: 8198626: java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac
  • dde959d: 8276808: java/nio/channels/Channels/TransferTo.java timed out
  • daf77eb: 8276337: Use override specifier in HeapDumper
  • 93692ea: 8274395: Use enhanced-for instead of plain 'for' in jdk.internal.jvmstat
  • e35abe3: 8256208: Javadoc's generated overview does not show classes of unnamed package
  • f65db88: 8276841: Add support for Visual Studio 2022
  • c27afb3: 8276863: Remove test/jdk/sun/security/ec/ECDSAJavaVerify.java
  • e198594: 8250678: ModuleDescriptor.Version parsing treats empty segments inconsistently
  • 4bd5bfd: 8276731: Metaspace chunks are uncommitted twice
  • ... and 294 more: https://git.openjdk.java.net/jdk/compare/98ab4b03b311dcd8374cbbb21a898298798750d6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 9, 2021
@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@hns Pushed as commit f9024d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
2 participants