Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275517: Off-by-one error in allocation #6018

Closed
wants to merge 1 commit into from
Closed

Conversation

mgronlun
Copy link

@mgronlun mgronlun commented Oct 19, 2021

Greetings (again),

The quick fix for JDK-8275445 includes an off-by-one error as part of the allocation. :-(

Sorry for this inconvenience.

Markus


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6018/head:pull/6018
$ git checkout pull/6018

Update a local copy of the PR:
$ git checkout pull/6018
$ git pull https://git.openjdk.java.net/jdk pull/6018/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6018

View PR using the GUI difftool:
$ git pr show -t 6018

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6018.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 19, 2021

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mgronlun
Copy link
Author

@mgronlun mgronlun commented Oct 19, 2021

/label hotspot-jfr hotspot-runtime serviceability

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm. Fingers crossed that this fixes the issues in CI.

@mgronlun
Copy link
Author

@mgronlun mgronlun commented Oct 19, 2021

Thanks @tschatzl for bringing this to attention, apologies for the inconvenience.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275517: Off-by-one error in allocation

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 8a3e0a1: 7008363: TEST_BUG: test/java/lang/StringCoding/CheckEncodings.sh does nothing and is very slow at that
  • a579483: 8274899: Replace usages of Collections.sort with List.sort call in jdk.hotspot.agent
  • 002c538: 8275287: Relax memory ordering constraints on updating instance class and array class counters

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr hotspot-jfr hotspot-runtime serviceability labels Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@mgronlun
The hotspot-jfr label was successfully added.

The hotspot-runtime label was successfully added.

The serviceability label was successfully added.

@mgronlun
Copy link
Author

@mgronlun mgronlun commented Oct 19, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

Going to push as commit 99bf7dd.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 8a3e0a1: 7008363: TEST_BUG: test/java/lang/StringCoding/CheckEncodings.sh does nothing and is very slow at that
  • a579483: 8274899: Replace usages of Collections.sort with List.sort call in jdk.hotspot.agent
  • 002c538: 8275287: Relax memory ordering constraints on updating instance class and array class counters

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@mgronlun Pushed as commit 99bf7dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 19, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-runtime integrated serviceability
2 participants