-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8254177: (tz) Upgrade time-zone data to tzdata2020b #602
Conversation
👋 Welcome back kravikumar! A progress list of the required criteria for merging this PR into |
@kiranoracle The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build changes look good.
@kiranoracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @naotoj, @coffeys) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I was wondering about the consequence of removing the "US/Pacific-New" zone names, but since the time zone should never have been introduced in the first place (it didn't become the law), I think no real world application would have used it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think we should release-note the removal of the "US/Pacific-New" Link on the off chance that some production/testing system is looking for such a zone.
Thanks for the review everyone, I have added a release note to the bug. I will integrate the changes |
/integrate |
@kiranoracle |
/sponsor |
@coffeys @kiranoracle Since your change was applied there have been 21 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 9c93490. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Looks like we both reached the same patch for this one independently :) |
Thanks for the comment, Andrew. I agree |
Hi Guys,
Please review the patch for tzdata2020b integration into JDK.
Release details can be found here:
https://mm.icann.org/pipermail/tz-announce/2020-October/000059.html
Bug: https://bugs.openjdk.java.net/browse/JDK-8254177
I had the pacificnew, systemv files removed from JDK repo and so TimeZoneName classes, make file and few test files need to be updated to incorporate the change.
The patch has passed all the related testing including JCK.
Thanks,
Kiran
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/602/head:pull/602
$ git checkout pull/602