Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254177: (tz) Upgrade time-zone data to tzdata2020b #602

Closed
wants to merge 3 commits into from

Conversation

@kiranoracle
Copy link

@kiranoracle kiranoracle commented Oct 12, 2020

Hi Guys,

Please review the patch for tzdata2020b integration into JDK.

Release details can be found here:

https://mm.icann.org/pipermail/tz-announce/2020-October/000059.html

Bug: https://bugs.openjdk.java.net/browse/JDK-8254177

I had the pacificnew, systemv files removed from JDK repo and so TimeZoneName classes, make file and few test files need to be updated to incorporate the change.

The patch has passed all the related testing including JCK.

Thanks,
Kiran


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254177: (tz) Upgrade time-zone data to tzdata2020b

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/602/head:pull/602
$ git checkout pull/602

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 12, 2020

👋 Welcome back kravikumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2020

@kiranoracle The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr label Oct 12, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 12, 2020

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Build changes look good.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2020

@kiranoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254177: (tz) Upgrade time-zone data to tzdata2020b

Reviewed-by: erikj, naoto, coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @naotoj, @coffeys) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 12, 2020
@naotoj
naotoj approved these changes Oct 12, 2020
Copy link
Member

@naotoj naotoj left a comment

Looks good to me.
I was wondering about the consequence of removing the "US/Pacific-New" zone names, but since the time zone should never have been introduced in the first place (it didn't become the law), I think no real world application would have used it.

Copy link
Contributor

@coffeys coffeys left a comment

Looks good. I think we should release-note the removal of the "US/Pacific-New" Link on the off chance that some production/testing system is looking for such a zone.

@kiranoracle
Copy link
Author

@kiranoracle kiranoracle commented Oct 13, 2020

Thanks for the review everyone, I have added a release note to the bug. I will integrate the changes

@kiranoracle
Copy link
Author

@kiranoracle kiranoracle commented Oct 13, 2020

/integrate

@openjdk openjdk bot added the sponsor label Oct 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2020

@kiranoracle
Your change (at version 0332727) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

@coffeys coffeys commented Oct 13, 2020

/sponsor

@openjdk openjdk bot closed this Oct 13, 2020
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Oct 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2020

@coffeys @kiranoracle Since your change was applied there have been 21 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 9c93490.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kiranoracle kiranoracle deleted the kiranoracle:JDK-8254177 branch Oct 13, 2020
@gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Oct 13, 2020

Looks like we both reached the same patch for this one independently :)
systemv was removed from tzdata some time ago and wasn't even being read by the JDK as far as I could see. Its contents are duplicated in jdk11_backward anyway.
Good to see both it and pacificnew being removed. In the unlikely event the removal of Pacific_New is problematic, it could be added to jdk11_backward as well, but it seems very unlikely.

@kiranoracle
Copy link
Author

@kiranoracle kiranoracle commented Oct 14, 2020

Thanks for the comment, Andrew. I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants