Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273678 TableAccessibility and TableRowAccessibility miss autorelease #6020

Closed
wants to merge 1 commit into from

Conversation

savoptik
Copy link
Contributor

@savoptik savoptik commented Oct 19, 2021

The TableAccessibility obj-c class should call [autorelease] on an object it allocates (see: [TableRowAccessibility alloc] and [ColumnAccessibility alloc]).

The TableRowAccessibility obj-c class should not call [retain] on an allocated object (see: [CellAccessibility alloc]).

"You own any object you create", see: https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/MemoryMgmt/Articles/mmRules.html

The logic of creating a CellAccessibility object will be reimplemented in the context of JDK-8275720.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273678: TableAccessibility and TableRowAccessibility miss autorelease

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6020/head:pull/6020
$ git checkout pull/6020

Update a local copy of the PR:
$ git checkout pull/6020
$ git pull https://git.openjdk.java.net/jdk pull/6020/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6020

View PR using the GUI difftool:
$ git pr show -t 6020

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6020.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2021

👋 Welcome back asemenov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2021
@openjdk
Copy link

openjdk bot commented Oct 19, 2021

@savoptik The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 19, 2021
@savoptik
Copy link
Contributor Author

/reviewer credit

@openjdk
Copy link

openjdk bot commented Oct 19, 2021

@savoptik Syntax: /reviewer (credit|remove) [@user | openjdk-user]+. For example:

  • /reviewer credit @openjdk-bot
  • /reviewer credit duke
  • /reviewer credit @user1 @user2

@savoptik
Copy link
Contributor Author

/reviewer credit @forantar

@openjdk
Copy link

openjdk bot commented Oct 19, 2021

@savoptik
Reviewer ant successfully credited.

@mlbridge
Copy link

mlbridge bot commented Oct 19, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 22, 2021

@savoptik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273678: TableAccessibility and TableRowAccessibility miss autorelease

Reviewed-by: ant, kizune, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 92 new commits pushed to the master branch:

  • 7cf68b1: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails
  • f610ef0: 8196440: Regression automated Test 'java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java' fails
  • f143d2a: 8268595: java/io/Serializable/serialFilter/GlobalFilterTest.java#id1 failed in timeout
  • 7f94302: 8275511: G1: Rename needs_remset_update to remset_is_tracked in G1HeapRegionAttr
  • 0bcc174: 8275717: Reimplement STATIC_ASSERT to use static_assert
  • f623298: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
  • 1da5e6b: 8275104: IR framework does not handle client VM builds correctly
  • 5dab76b: 8275381: G1: refactor 2 constructors of G1CardSetConfiguration
  • 5bbe4ca: 8275293: A change done with JDK-8268764 mismatches the java.rmi.server.ObjID.hashCode spec
  • c94dc2a: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
  • ... and 82 more: https://git.openjdk.java.net/jdk/compare/fd10f1996ef94529b5b12e547957cd904ade1956...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@forantar, @azuev-java, @pankaj-bansal) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 22, 2021
Copy link
Member

@azuev-java azuev-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@savoptik
Copy link
Contributor Author

@pankaj-bansal please review

@savoptik
Copy link
Contributor Author

/reviewer credit @pankaj-bansal

@openjdk
Copy link

openjdk bot commented Oct 25, 2021

@savoptik
Reviewer pbansal successfully credited.

@savoptik
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 25, 2021
@openjdk
Copy link

openjdk bot commented Oct 25, 2021

@savoptik
Your change (at version d7e512f) is now ready to be sponsored by a Committer.

@forantar
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 25, 2021

Going to push as commit 3221a14.
Since your change was applied there have been 92 commits pushed to the master branch:

  • 7cf68b1: 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails
  • f610ef0: 8196440: Regression automated Test 'java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java' fails
  • f143d2a: 8268595: java/io/Serializable/serialFilter/GlobalFilterTest.java#id1 failed in timeout
  • 7f94302: 8275511: G1: Rename needs_remset_update to remset_is_tracked in G1HeapRegionAttr
  • 0bcc174: 8275717: Reimplement STATIC_ASSERT to use static_assert
  • f623298: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
  • 1da5e6b: 8275104: IR framework does not handle client VM builds correctly
  • 5dab76b: 8275381: G1: refactor 2 constructors of G1CardSetConfiguration
  • 5bbe4ca: 8275293: A change done with JDK-8268764 mismatches the java.rmi.server.ObjID.hashCode spec
  • c94dc2a: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
  • ... and 82 more: https://git.openjdk.java.net/jdk/compare/fd10f1996ef94529b5b12e547957cd904ade1956...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 25, 2021
@openjdk
Copy link

openjdk bot commented Oct 25, 2021

@forantar @savoptik Pushed as commit 3221a14.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants