8272614: Unused parameters in MethodHandleNatives linking methods

[hseigel]

Please review this small fix for JDK-8272614 to remove the unused indexInCP argument to linkCallSite() and linkDynamicConstant(). The fix was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-6 on Linux x64.

Thanks, Harold

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8272614: Unused parameters in MethodHandleNatives linking methods

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Lois Foltan (@lfoltan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6021/head:pull/6021
$ git checkout pull/6021

Update a local copy of the PR:
$ git checkout pull/6021
$ git pull https://git.openjdk.java.net/jdk pull/6021/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6021

View PR using the GUI difftool:
$ git pr show -t 6021

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6021.diff

[bridgekeeper]

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hseigel The following labels will be automatically applied to this pull request:

• core-libs
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0d9a518b)

[dholmes-ora]

LGTM!

Thanks,
David

[openjdk]

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272614: Unused parameters in MethodHandleNatives linking methods

Reviewed-by: dholmes, lfoltan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• 7e28bdd: 8275055: Improve HeapRegionRemSet::split_card()
• 35e5bb5: 8269336: Malformed jdk.serialFilter incorrectly handled
• 043cde2: 8275319: java.net.NetworkInterface throws java.lang.Error instead of SocketException
• a91a0a5: 8233724: Remove -Wc++14-compat warning suppression in operator_new.cpp
• 1271fbf: 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds
• 135cf3c: 8275439: Remove PrintVtableStats
• 50a5723: 8274910: Compile in G1 evacuation failure injection code based on define
• 5454a76: 8275273: Add missing HtmlStyle documentation
• bd0bed7: 8273317: crash in cmovP_cmpP_zero_zeroNode::bottom_type()
• 77b2789: 7124287: [macosx] JTableHeader doesn't get focus after pressing F8 key
• ... and 39 more: https://git.openjdk.java.net/jdk/compare/98ab4b03b311dcd8374cbbb21a898298798750d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lfoltan]

LGTM!

[hseigel]

Thanks David and Lois!

/integrate

[openjdk]

Going to push as commit bbc6061.
Since your change was applied there have been 49 commits pushed to the master branch:

• 7e28bdd: 8275055: Improve HeapRegionRemSet::split_card()
• 35e5bb5: 8269336: Malformed jdk.serialFilter incorrectly handled
• 043cde2: 8275319: java.net.NetworkInterface throws java.lang.Error instead of SocketException
• a91a0a5: 8233724: Remove -Wc++14-compat warning suppression in operator_new.cpp
• 1271fbf: 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds
• 135cf3c: 8275439: Remove PrintVtableStats
• 50a5723: 8274910: Compile in G1 evacuation failure injection code based on define
• 5454a76: 8275273: Add missing HtmlStyle documentation
• bd0bed7: 8273317: crash in cmovP_cmpP_zero_zeroNode::bottom_type()
• 77b2789: 7124287: [macosx] JTableHeader doesn't get focus after pressing F8 key
• ... and 39 more: https://git.openjdk.java.net/jdk/compare/98ab4b03b311dcd8374cbbb21a898298798750d6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@hseigel Pushed as commit bbc6061.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.