Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds #6023

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Oct 19, 2021

Please review this small change to enable CHECK_UNHANDLED_OOPs for Windows fastdebug builds. The change was tested by running Mach5 tiers 1-6 on Windows-x64-debug.

Thanks, Harold


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6023/head:pull/6023
$ git checkout pull/6023

Update a local copy of the PR:
$ git checkout pull/6023
$ git pull https://git.openjdk.java.net/jdk pull/6023/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6023

View PR using the GUI difftool:
$ git pr show -t 6023

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6023.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 19, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@hseigel The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Oct 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 19, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Seems fine to me.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds

Reviewed-by: dholmes, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 19, 2021
Copy link
Member

@erikj79 erikj79 left a comment

Looks good to me.

@hseigel
Copy link
Member Author

@hseigel hseigel commented Oct 20, 2021

Thanks David and Erik!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2021

Going to push as commit 1271fbf.
Since your change was applied there have been 44 commits pushed to the master branch:

  • 135cf3c: 8275439: Remove PrintVtableStats
  • 50a5723: 8274910: Compile in G1 evacuation failure injection code based on define
  • 5454a76: 8275273: Add missing HtmlStyle documentation
  • bd0bed7: 8273317: crash in cmovP_cmpP_zero_zeroNode::bottom_type()
  • 77b2789: 7124287: [macosx] JTableHeader doesn't get focus after pressing F8 key
  • c24fb85: 8275512: Upgrade required version of jtreg to 6.1
  • 926966b: 8275003: Suppress warnings on non-serializable non-transient instance fields in windows mscapi
  • e63c148: 8264849: Add KW and KWP support to PKCS11 provider
  • bd2b41d: 8275252: Migrate cacerts from JKS to password-less PKCS12
  • 54a29a4: 8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails
  • ... and 34 more: https://git.openjdk.java.net/jdk/compare/98ab4b03b311dcd8374cbbb21a898298798750d6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2021

@hseigel Pushed as commit 1271fbf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
3 participants