Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275449: Add linux-aarch64-zero build profile #6024

Closed

Conversation

mseledts
Copy link
Member

@mseledts mseledts commented Oct 19, 2021

Please review this small change that adds the linux-aarch64 zero build profile.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6024/head:pull/6024
$ git checkout pull/6024

Update a local copy of the PR:
$ git checkout pull/6024
$ git pull https://git.openjdk.java.net/jdk pull/6024/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6024

View PR using the GUI difftool:
$ git pr show -t 6024

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6024.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 19, 2021

👋 Welcome back mseledtsov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mseledts
Copy link
Member Author

@mseledts mseledts commented Oct 19, 2021

Testing:

  • linux-aarch64 zero build - PASS
  • major platform builds: linux-x64, linux-aarch64, windows-x64, macosx-x64, macosx-aarch64 - PASS

@openjdk openjdk bot added the rfr label Oct 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2021

@mseledts The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Oct 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 19, 2021

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Looks good otherwise.

@@ -149,7 +149,7 @@ AC_DEFUN_ONCE([LIB_SETUP_LIBFFI],
else
AC_MSG_ERROR([Could not locate libffi.so.? for bundling])
fi
elif test "x${OPENJDK_TARGET_CPU}" = "xx86_64"; then
elif ((test "x${OPENJDK_TARGET_CPU}" = "xx86_64") || (test "x${OPENJDK_TARGET_CPU}" = "xaarch64")); then
Copy link
Member

@erikj79 erikj79 Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using parens like this in shell isn't wrong, but it's not a pattern we commonly use in these files.

Copy link
Member

@magicus magicus Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might add that each layer of () spawns a new subshell, which is noticably slow on cygwin. So please remove them.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2021

@mseledts This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275449: Add linux-aarch64-zero build profile

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 97 new commits pushed to the master branch:

  • 46b5bfb: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
  • bbc6061: 8272614: Unused parameters in MethodHandleNatives linking methods
  • 7e28bdd: 8275055: Improve HeapRegionRemSet::split_card()
  • 35e5bb5: 8269336: Malformed jdk.serialFilter incorrectly handled
  • 043cde2: 8275319: java.net.NetworkInterface throws java.lang.Error instead of SocketException
  • a91a0a5: 8233724: Remove -Wc++14-compat warning suppression in operator_new.cpp
  • 1271fbf: 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds
  • 135cf3c: 8275439: Remove PrintVtableStats
  • 50a5723: 8274910: Compile in G1 evacuation failure injection code based on define
  • 5454a76: 8275273: Add missing HtmlStyle documentation
  • ... and 87 more: https://git.openjdk.java.net/jdk/compare/d9e03e42afbb2e5115b67accfffad4938b8314b1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 20, 2021
@@ -149,7 +149,7 @@ AC_DEFUN_ONCE([LIB_SETUP_LIBFFI],
else
AC_MSG_ERROR([Could not locate libffi.so.? for bundling])
fi
elif test "x${OPENJDK_TARGET_CPU}" = "xx86_64"; then
elif ((test "x${OPENJDK_TARGET_CPU}" = "xx86_64") || (test "x${OPENJDK_TARGET_CPU}" = "xaarch64")); then
Copy link
Member

@magicus magicus Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might add that each layer of () spawns a new subshell, which is noticably slow on cygwin. So please remove them.

@mseledts
Copy link
Member Author

@mseledts mseledts commented Oct 20, 2021

Thanks for review. I have removed the extra brackets and re-tested.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2021

Going to push as commit 0021a2f.
Since your change was applied there have been 97 commits pushed to the master branch:

  • 46b5bfb: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
  • bbc6061: 8272614: Unused parameters in MethodHandleNatives linking methods
  • 7e28bdd: 8275055: Improve HeapRegionRemSet::split_card()
  • 35e5bb5: 8269336: Malformed jdk.serialFilter incorrectly handled
  • 043cde2: 8275319: java.net.NetworkInterface throws java.lang.Error instead of SocketException
  • a91a0a5: 8233724: Remove -Wc++14-compat warning suppression in operator_new.cpp
  • 1271fbf: 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds
  • 135cf3c: 8275439: Remove PrintVtableStats
  • 50a5723: 8274910: Compile in G1 evacuation failure injection code based on define
  • 5454a76: 8275273: Add missing HtmlStyle documentation
  • ... and 87 more: https://git.openjdk.java.net/jdk/compare/d9e03e42afbb2e5115b67accfffad4938b8314b1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2021

@mseledts Pushed as commit 0021a2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
3 participants