8275449: Add linux-aarch64-zero build profile #6024

mseledts · 2021-10-19T23:22:06Z

Please review this small change that adds the linux-aarch64 zero build profile.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8275449: Add linux-aarch64-zero build profile

Reviewers

Erik Joelsson (@erikj79 - Reviewer) ⚠️ Review applies to fba2545

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6024/head:pull/6024
$ git checkout pull/6024

Update a local copy of the PR:
$ git checkout pull/6024
$ git pull https://git.openjdk.java.net/jdk pull/6024/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6024

View PR using the GUI difftool:
$ git pr show -t 6024

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6024.diff

bridgekeeper · 2021-10-19T23:22:43Z

👋 Welcome back mseledtsov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

mseledts · 2021-10-19T23:23:58Z

Testing:

linux-aarch64 zero build - PASS
major platform builds: linux-x64, linux-aarch64, windows-x64, macosx-x64, macosx-aarch64 - PASS

openjdk · 2021-10-19T23:24:44Z

@mseledts The following label will be automatically applied to this pull request:

build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-10-19T23:28:23Z

Webrevs

01: Full - Incremental (068e1a54)
00: Full (fba2545c)

erikj79

Looks good otherwise.

erikj79 · 2021-10-20T00:10:30Z

make/autoconf/lib-ffi.m4

@@ -149,7 +149,7 @@ AC_DEFUN_ONCE([LIB_SETUP_LIBFFI],
          else
            AC_MSG_ERROR([Could not locate libffi.so.? for bundling])
          fi
-        elif test "x${OPENJDK_TARGET_CPU}" = "xx86_64"; then
+        elif ((test "x${OPENJDK_TARGET_CPU}" = "xx86_64") || (test "x${OPENJDK_TARGET_CPU}" = "xaarch64")); then


Using parens like this in shell isn't wrong, but it's not a pattern we commonly use in these files.

I might add that each layer of () spawns a new subshell, which is noticably slow on cygwin. So please remove them.

openjdk · 2021-10-20T00:11:57Z

@mseledts This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275449: Add linux-aarch64-zero build profile

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 97 new commits pushed to the master branch:

46b5bfb: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
bbc6061: 8272614: Unused parameters in MethodHandleNatives linking methods
7e28bdd: 8275055: Improve HeapRegionRemSet::split_card()
35e5bb5: 8269336: Malformed jdk.serialFilter incorrectly handled
043cde2: 8275319: java.net.NetworkInterface throws java.lang.Error instead of SocketException
a91a0a5: 8233724: Remove -Wc++14-compat warning suppression in operator_new.cpp
1271fbf: 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds
135cf3c: 8275439: Remove PrintVtableStats
50a5723: 8274910: Compile in G1 evacuation failure injection code based on define
5454a76: 8275273: Add missing HtmlStyle documentation
... and 87 more: https://git.openjdk.java.net/jdk/compare/d9e03e42afbb2e5115b67accfffad4938b8314b1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

magicus · 2021-10-20T10:32:21Z

make/autoconf/lib-ffi.m4

@@ -149,7 +149,7 @@ AC_DEFUN_ONCE([LIB_SETUP_LIBFFI],
          else
            AC_MSG_ERROR([Could not locate libffi.so.? for bundling])
          fi
-        elif test "x${OPENJDK_TARGET_CPU}" = "xx86_64"; then
+        elif ((test "x${OPENJDK_TARGET_CPU}" = "xx86_64") || (test "x${OPENJDK_TARGET_CPU}" = "xaarch64")); then


I might add that each layer of () spawns a new subshell, which is noticably slow on cygwin. So please remove them.

mseledts · 2021-10-20T18:16:06Z

Thanks for review. I have removed the extra brackets and re-tested.

/integrate

openjdk · 2021-10-20T18:17:09Z

Going to push as commit 0021a2f.
Since your change was applied there have been 97 commits pushed to the master branch:

46b5bfb: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
bbc6061: 8272614: Unused parameters in MethodHandleNatives linking methods
7e28bdd: 8275055: Improve HeapRegionRemSet::split_card()
35e5bb5: 8269336: Malformed jdk.serialFilter incorrectly handled
043cde2: 8275319: java.net.NetworkInterface throws java.lang.Error instead of SocketException
a91a0a5: 8233724: Remove -Wc++14-compat warning suppression in operator_new.cpp
1271fbf: 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds
135cf3c: 8275439: Remove PrintVtableStats
50a5723: 8274910: Compile in G1 evacuation failure injection code based on define
5454a76: 8275273: Add missing HtmlStyle documentation
... and 87 more: https://git.openjdk.java.net/jdk/compare/d9e03e42afbb2e5115b67accfffad4938b8314b1...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-10-20T18:17:26Z

@mseledts Pushed as commit 0021a2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

mseledts added 2 commits Oct 19, 2021

Add aarch64 as target CPU for libffi lookup

3497ea6

Add linux-aarch64-zero to jib build profiles

fba2545

openjdk bot added the rfr label Oct 19, 2021

openjdk bot added the build label Oct 19, 2021

erikj79 approved these changes Oct 20, 2021

View changes

openjdk bot added the ready label Oct 20, 2021

magicus suggested changes Oct 20, 2021

View changes

Removing extra brackets per review feedback

068e1a5

openjdk bot closed this Oct 20, 2021

openjdk bot added integrated and removed ready rfr labels Oct 20, 2021

8275449: Add linux-aarch64-zero build profile #6024

8275449: Add linux-aarch64-zero build profile #6024

mseledts commented Oct 19, 2021 •

edited by openjdk[bot] bot

bridgekeeper bot commented Oct 19, 2021

mseledts commented Oct 19, 2021

openjdk bot commented Oct 19, 2021

mlbridge bot commented Oct 19, 2021 •

edited

erikj79 left a comment

erikj79 Oct 20, 2021

magicus Oct 20, 2021

openjdk bot commented Oct 20, 2021 •

edited

magicus Oct 20, 2021

mseledts commented Oct 20, 2021

openjdk bot commented Oct 20, 2021

openjdk bot commented Oct 20, 2021

8275449: Add linux-aarch64-zero build profile #6024

8275449: Add linux-aarch64-zero build profile #6024

Conversation

mseledts commented Oct 19, 2021 • edited by openjdk[bot] bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Oct 19, 2021

mseledts commented Oct 19, 2021

openjdk bot commented Oct 19, 2021

mlbridge bot commented Oct 19, 2021 • edited

Webrevs

erikj79 left a comment

erikj79 Oct 20, 2021

Choose a reason for hiding this comment

magicus Oct 20, 2021

Choose a reason for hiding this comment

openjdk bot commented Oct 20, 2021 • edited

magicus Oct 20, 2021

Choose a reason for hiding this comment

mseledts commented Oct 20, 2021

openjdk bot commented Oct 20, 2021

openjdk bot commented Oct 20, 2021

mseledts commented Oct 19, 2021 •

edited by openjdk[bot] bot

mlbridge bot commented Oct 19, 2021 •

edited

openjdk bot commented Oct 20, 2021 •

edited