Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275604: Zero: Reformat opclabels_data #6031

Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 20, 2021

This is a formatting-only patch that formats opclabels_data array to be more readable.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6031/head:pull/6031
$ git checkout pull/6031

Update a local copy of the PR:
$ git checkout pull/6031
$ git pull https://git.openjdk.java.net/jdk pull/6031/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6031

View PR using the GUI difftool:
$ git pr show -t 6031

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6031.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 20, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2021

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Oct 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 20, 2021

Webrevs

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 25, 2021

Any takers? :)

adinn
adinn approved these changes Nov 3, 2021
Copy link
Contributor

@adinn adinn left a comment

Looks fineto me.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275604: Zero: Reformat opclabels_data

Reviewed-by: adinn, zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 227 new commits pushed to the master branch:

  • 6150633: 8276348: Use blessed modifier order in java.base
  • 465d350: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
  • 7439b59: 8276044: ciReplay: C1 does not dump a replay file when using DumpReplay as compile command option
  • 87b926e: 8275086: compiler/c2/irTests/TestPostParseCallDevirtualization.java fails when compiler1 is disabled
  • 2b02b6f: 8274942: AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
  • bb92fb0: 8274930: sun/tools/jps/TestJps.java can fail with long VM arguments string
  • 6a04899: 8275840: Add test to java/nio/channels/Channels/TransferTo.java to test transfer sizes > 2GB
  • 01105d6: 8276367: ProblemList vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java
  • 8fc16f1: 8275729: Qualified method names in CodeHeap Analytics
  • fa4ce82: 8276260: (se) Remove java/nio/channels/Selector/Wakeup.java from ProblemList (win)
  • ... and 217 more: https://git.openjdk.java.net/jdk/compare/31500692d1503cb73249e0425e6930aaaa49258a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 3, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Nov 3, 2021

Thank you! Trivial, right?

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

LGTM

@adinn
Copy link
Contributor

@adinn adinn commented Nov 3, 2021

Thank you! Trivial, right?

Indeed.

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Nov 3, 2021

Thanks!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

Going to push as commit 724bf3b.
Since your change was applied there have been 231 commits pushed to the master branch:

  • 61cb4bc: 8276036: The value of full_count in the message of insufficient codecache is wrong
  • 8731846: 8276556: ProblemList java/nio/channels/FileChannel/LargeGatheringWrite.java on windows-x64
  • be1ca2b: 8276298: G1: Remove unused G1SegmentedArrayBufferList::add
  • a316c06: 8275730: Relax memory constraint on MultiThreadedRefCounter
  • 6150633: 8276348: Use blessed modifier order in java.base
  • 465d350: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
  • 7439b59: 8276044: ciReplay: C1 does not dump a replay file when using DumpReplay as compile command option
  • 87b926e: 8275086: compiler/c2/irTests/TestPostParseCallDevirtualization.java fails when compiler1 is disabled
  • 2b02b6f: 8274942: AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
  • bb92fb0: 8274930: sun/tools/jps/TestJps.java can fail with long VM arguments string
  • ... and 221 more: https://git.openjdk.java.net/jdk/compare/31500692d1503cb73249e0425e6930aaaa49258a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

@shipilev Pushed as commit 724bf3b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8275604-zero-reformat-opclabels branch Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
3 participants