Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274988 G1: refine G1SegmentedArrayAllocOptions and G1CardSetAllocOptions #6032

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Oct 20, 2021

This is a follow-up of JDK-8273626. (something mentioned in Description was already done in JDK-8273626)
Some other cleanups need to be done:
Some fields of G1SegmentedArrayAllocOptions better be reloated to G1CardSetAllocOptions, and some fields are const, and also adds some assert.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274988: G1: refine G1SegmentedArrayAllocOptions and G1CardSetAllocOptions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6032/head:pull/6032
$ git checkout pull/6032

Update a local copy of the PR:
$ git checkout pull/6032
$ git pull https://git.openjdk.java.net/jdk pull/6032/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6032

View PR using the GUI difftool:
$ git pr show -t 6032

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6032.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 20, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Oct 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 20, 2021

Webrevs

src/hotspot/share/gc/g1/g1CardSetMemory.hpp Outdated Show resolved Hide resolved
@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2021

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274988: G1: refine G1SegmentedArrayAllocOptions and G1CardSetAllocOptions

Reviewed-by: tschatzl, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • c7a80e6: 8275607: G1: G1CardSetAllocator::drop_all needs to call G1SegmentedArray::drop_all
  • af7c56b: 8275167: x86 intrinsic for unsignedMultiplyHigh
  • cea3f01: 8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless
  • d1e3ca4: 8233558: [TESTBUG] WindowOwnedByEmbeddedFrameTest.java fails on macos
  • 913f928: 8273507: Convert test/jdk/java/nio/channels/Channels/TransferTo.java to TestNG test
  • 0021a2f: 8275449: Add linux-aarch64-zero build profile
  • 46b5bfb: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
  • bbc6061: 8272614: Unused parameters in MethodHandleNatives linking methods
  • 7e28bdd: 8275055: Improve HeapRegionRemSet::split_card()
  • 35e5bb5: 8269336: Malformed jdk.serialFilter incorrectly handled
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/c24fb852f20bf0fc2817dfed52ff1609a5bced59...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 20, 2021
@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Oct 21, 2021

Thanks @tschatzl @albertnetymk for your reviews.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

Going to push as commit a120937.
Since your change was applied there have been 18 commits pushed to the master branch:

  • c7a80e6: 8275607: G1: G1CardSetAllocator::drop_all needs to call G1SegmentedArray::drop_all
  • af7c56b: 8275167: x86 intrinsic for unsignedMultiplyHigh
  • cea3f01: 8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless
  • d1e3ca4: 8233558: [TESTBUG] WindowOwnedByEmbeddedFrameTest.java fails on macos
  • 913f928: 8273507: Convert test/jdk/java/nio/channels/Channels/TransferTo.java to TestNG test
  • 0021a2f: 8275449: Add linux-aarch64-zero build profile
  • 46b5bfb: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
  • bbc6061: 8272614: Unused parameters in MethodHandleNatives linking methods
  • 7e28bdd: 8275055: Improve HeapRegionRemSet::split_card()
  • 35e5bb5: 8269336: Malformed jdk.serialFilter incorrectly handled
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/c24fb852f20bf0fc2817dfed52ff1609a5bced59...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

@Hamlin-Li Pushed as commit a120937.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the refactor.constructors.G1XxxAllocOptions.v2 branch Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants