New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274988 G1: refine G1SegmentedArrayAllocOptions and G1CardSetAllocOptions #6032
8274988 G1: refine G1SegmentedArrayAllocOptions and G1CardSetAllocOptions #6032
Conversation
|
@Hamlin-Li The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@Hamlin-Li This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thanks @tschatzl @albertnetymk for your reviews. /integrate |
Going to push as commit a120937.
Your commit was automatically rebased without conflicts. |
@Hamlin-Li Pushed as commit a120937. |
This is a follow-up of JDK-8273626. (something mentioned in Description was already done in JDK-8273626)
Some other cleanups need to be done:
Some fields of G1SegmentedArrayAllocOptions better be reloated to G1CardSetAllocOptions, and some fields are const, and also adds some assert.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6032/head:pull/6032
$ git checkout pull/6032
Update a local copy of the PR:
$ git checkout pull/6032
$ git pull https://git.openjdk.java.net/jdk pull/6032/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6032
View PR using the GUI difftool:
$ git pr show -t 6032
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6032.diff