New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274714: Incorrect verifier protected access error message #6042
Conversation
|
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please add a comment to the jasm file explaining why you need jasm to express what it is expressing.
Thanks,
David
@hseigel This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks David and Coleen for reviewing this! /integrate |
Going to push as commit e39bdc9.
Your commit was automatically rebased without conflicts. |
Please review this small change to fix a Verifier error message so that it displays the right bytecode. The fix was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows.
Thanks, Harold
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6042/head:pull/6042
$ git checkout pull/6042
Update a local copy of the PR:
$ git checkout pull/6042
$ git pull https://git.openjdk.java.net/jdk pull/6042/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6042
View PR using the GUI difftool:
$ git pr show -t 6042
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6042.diff