Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254576: ZGC: Clean up timers in roots iterators #605

Closed
wants to merge 1 commit into from

Conversation

pliden
Copy link
Contributor

@pliden pliden commented Oct 12, 2020

Some of the timers in roots iterators are no longer that interesting after JDK-8253180 (concurrent thread stack scanning). I propose we remove them. This patch also adjusts the line break of a comment and moves a closure closer to the function where it's used.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/605/head:pull/605
$ git checkout pull/605

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 12, 2020

👋 Welcome back pliden! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 12, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2020

@pliden The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Oct 12, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 12, 2020

Webrevs

fisk
fisk approved these changes Oct 12, 2020
Copy link
Contributor

@fisk fisk left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2020

@pliden This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254576: ZGC: Clean up timers in roots iterators

Reviewed-by: eosterlund, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 508c8a9: 8247591: Document Alpine Linux build steps in OpenJDK build guide
  • 63009f9: 8247589: Implementation of Alpine Linux/x64 Port

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 12, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2020

@pliden this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8254576_clean_up_timers
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict and removed ready labels Oct 13, 2020
@pliden pliden force-pushed the 8254576_clean_up_timers branch from bd8bf09 to a80e19c Compare Oct 13, 2020
@openjdk openjdk bot added ready and removed merge-conflict labels Oct 13, 2020
@pliden
Copy link
Contributor Author

@pliden pliden commented Oct 13, 2020

/integrate

@openjdk openjdk bot closed this Oct 13, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2020

@pliden Since your change was applied there have been 2 commits pushed to the master branch:

  • 508c8a9: 8247591: Document Alpine Linux build steps in OpenJDK build guide
  • 63009f9: 8247589: Implementation of Alpine Linux/x64 Port

Your commit was automatically rebased without conflicts.

Pushed as commit 5d6a625.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pliden pliden deleted the 8254576_clean_up_timers branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants