Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless #6050

Closed
wants to merge 1 commit into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Oct 20, 2021

Hi all,

could you please review this tiny patch?

from JBS:

serviceability/jvmti/GetObjectSizeClass.java doesn't ignore external flags (where it matters) and hence should not have been marked w/ vm.flagless

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6050/head:pull/6050
$ git checkout pull/6050

Update a local copy of the PR:
$ git checkout pull/6050
$ git pull https://git.openjdk.java.net/jdk pull/6050/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6050

View PR using the GUI difftool:
$ git pr show -t 6050

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6050.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8275666 8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless Oct 20, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2021
@openjdk
Copy link

openjdk bot commented Oct 20, 2021

@iignatev The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Oct 20, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 20, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless

Reviewed-by: lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d1e3ca4: 8233558: [TESTBUG] WindowOwnedByEmbeddedFrameTest.java fails on macos
  • 913f928: 8273507: Convert test/jdk/java/nio/channels/Channels/TransferTo.java to TestNG test

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 20, 2021
@iignatev
Copy link
Member Author

iignatev commented Oct 20, 2021

Thanks Leonid!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 20, 2021

Going to push as commit cea3f01.
Since your change was applied there have been 2 commits pushed to the master branch:

  • d1e3ca4: 8233558: [TESTBUG] WindowOwnedByEmbeddedFrameTest.java fails on macos
  • 913f928: 8273507: Convert test/jdk/java/nio/channels/Channels/TransferTo.java to TestNG test

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2021
@openjdk
Copy link

openjdk bot commented Oct 20, 2021

@iignatev Pushed as commit cea3f01.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants