Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails #6056

Closed
wants to merge 3 commits into from

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Oct 21, 2021

Looks like the test does not fail anymore.

However some cleanup was made:

  • fixed wildcard imports
  • frame centered and explicitly disposed at the end
  • removed unused setAutoDelay() call (no key/mouse key events generated)
  • improved variable naming

Testing still green.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6056/head:pull/6056
$ git checkout pull/6056

Update a local copy of the PR:
$ git checkout pull/6056
$ git pull https://git.openjdk.java.net/jdk pull/6056/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6056

View PR using the GUI difftool:
$ git pr show -t 6056

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6056.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 21, 2021

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Oct 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 21, 2021

Webrevs

@@ -24,70 +24,69 @@
/*
@test 1.0 04/05/20
@key headful
@bug 4140484
@bug 4140484 8202932
Copy link
Member

@mrserb mrserb Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW it is not necessary to update bugid for the simple cleanups, this is for the bugs which can be verified by this test, or for some big logic rework in the test. So for every next test update, it will be easy to check that the old bugs still can be verified by the updated test. In the current case it is clear that the test should fail before 4140484 was fixed.

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 22, 2021

Did you check the possibility to verify JDK-4140484, I think it should be possible but just in case.

@azvegint
Copy link
Member Author

@azvegint azvegint commented Oct 22, 2021

Did you check the possibility to verify JDK-4140484, I think it should be possible but just in case.

Original test cases from JDK-4140484 description are still have no issues.

Hundreds of runs of this test on mach5 has not a single failure(nor before nor after modification)

However I've added delay after setVisible() call for extra safety.

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 22, 2021

Did you check the possibility to verify JDK-4140484, I think it should be possible but just in case.

Original test cases from JDK-4140484 description are still have no issues.

Please clarify, did the updated test fail before that fix, and pass after?

@azvegint
Copy link
Member Author

@azvegint azvegint commented Oct 22, 2021

Please clarify, did the updated test fail before that fix, and pass after?

Unfortunately I could not find a correct repo location for jdk6 containing the original fix changeset.

All I've found is a bunch of mercurial repos jdk6u*/j2se, which are containing the fix, but has no history about it, since it was loaded along with Initial load changeset.

IIRC it should be something other than mercurial(SVN or smth else), but still have no idea where to find it.

The fix proposed in JDK-4140484 comments is too far away from current code.

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 23, 2021

It was fixed in jdk6 but reported for the early release, so probably it can reproduce the bug in jdk5?

@azvegint
Copy link
Member Author

@azvegint azvegint commented Oct 23, 2021

Yes, it is reproducible with jdk1.5, and not reproducible with jdk1.6 at least on Windows(jdk1.5 on Linux won't launch)

mrserb
mrserb approved these changes Oct 25, 2021
Copy link
Member

@mrserb mrserb left a comment

Thank you for confirmation, looks fine.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 89 new commits pushed to the master branch:

  • 5bbe4ca: 8275293: A change done with JDK-8268764 mismatches the java.rmi.server.ObjID.hashCode spec
  • c94dc2a: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
  • fec470f: 8272163: Add -version option to keytool and jarsigner
  • 6523c55: 8198336: java/awt/FontMetrics/FontCrash.java fails in headless mode
  • 88bbf3c: 8273111: Default timezone should return zone ID if /etc/localtime is valid but not canonicalization on linux
  • 4dec8fc: 8275645: [JVMCI] avoid unaligned volatile reads on AArch64
  • 4e647aa: 8275416: G1: remove unnecessary make_referent_alive in precleaning phase
  • dd622e5: 8275783: G1: fix incorrect region type documentation in HeapRegionType
  • b2128a9: 8263155: Allow additional contents for DMG
  • 1efe946: 8275712: Hashtable literal_size functions are broken
  • ... and 79 more: https://git.openjdk.java.net/jdk/compare/98ab4b03b311dcd8374cbbb21a898298798750d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 25, 2021
@azvegint
Copy link
Member Author

@azvegint azvegint commented Oct 25, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

Going to push as commit 7cf68b1.
Since your change was applied there have been 96 commits pushed to the master branch:

  • f610ef0: 8196440: Regression automated Test 'java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java' fails
  • f143d2a: 8268595: java/io/Serializable/serialFilter/GlobalFilterTest.java#id1 failed in timeout
  • 7f94302: 8275511: G1: Rename needs_remset_update to remset_is_tracked in G1HeapRegionAttr
  • 0bcc174: 8275717: Reimplement STATIC_ASSERT to use static_assert
  • f623298: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
  • 1da5e6b: 8275104: IR framework does not handle client VM builds correctly
  • 5dab76b: 8275381: G1: refactor 2 constructors of G1CardSetConfiguration
  • 5bbe4ca: 8275293: A change done with JDK-8268764 mismatches the java.rmi.server.ObjID.hashCode spec
  • c94dc2a: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
  • fec470f: 8272163: Add -version option to keytool and jarsigner
  • ... and 86 more: https://git.openjdk.java.net/jdk/compare/98ab4b03b311dcd8374cbbb21a898298798750d6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

@azvegint Pushed as commit 7cf68b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated
2 participants