8254575: C2: Clean up unused TRACK_PHI_INPUTS assertion code

[robcasloz]

Remove assertion code that was disabled in all build configurations.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8254575: C2: Clean up unused TRACK_PHI_INPUTS assertion code

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Contributors

• Vladimir Ivanov <vlivanov@openjdk.org>

Download

$ git fetch https://git.openjdk.java.net/jdk pull/606/head:pull/606
$ git checkout pull/606

[bridgekeeper]

👋 Welcome back robcasloz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[robcasloz]

/summary
Remove assertion code that was disabled in all build configurations.

[openjdk]

@robcasloz Setting summary to Remove assertion code that was disabled in all build configurations.

[openjdk]

@robcasloz The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[robcasloz]

/contributor add vlivanov

[openjdk]

@robcasloz
Contributor Vladimir Ivanov <vlivanov@openjdk.org> successfully added.

[robcasloz]

Tested by building on windows-x64, linux-x64, and macosx-x64 (all in both debug and release mode).

[mlbridge]

Webrevs

• 00: Full (cd010f1)

[iwanowww]

Looks good.

[openjdk]

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254575: C2: Clean up unused TRACK_PHI_INPUTS assertion code

Remove assertion code that was disabled in all build configurations.

Co-authored-by: Vladimir Ivanov <vlivanov@openjdk.org>
Reviewed-by: vlivanov, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• a098037: 8254365: ciMethod.hpp should not include methodHandles.hpp
• d50e0de: 8254722: bsd_zero builds broken after JDK-8253717
• ba5dc67: 8254158: Consolidate per-platform stack overflow handling code
• 715e24a: 8254311: Incorrect statements in createWindowsDevkit2017.sh
• ba24f96: 8251861: Remove unused jdk.internal.ref.SoftCleanable and WeakCleanable
• 6ed4c89: 8254704: Add missing @SInCE tag to BodyPublishers::concat
• 3fb2e82: 8254627: Cleanup {Abstract,Single,Split}IndexWriter classes
• 02d9c29: 8254672: ZGC: ZParallelOopsDo/ZSerialWeakOopsDo should use atomic load/store
• 65393a0: 8229867: Re-examine synchronization usages in http and https protocol handlers
• 6fe209b: 8254671: ZGC: Remove unused roots iterator types
• ... and 24 more: https://git.openjdk.java.net/jdk/compare/54bbe76ed0ce90cea43864da3de7d18a7bbaa196...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iwanowww, @vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[vnkozlov]

Good.

[robcasloz]

Thanks for the reviews!

[robcasloz]

/integrate

[openjdk]

@robcasloz
Your change (at version cd010f1) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

@TobiHartmann @robcasloz Since your change was applied there have been 35 commits pushed to the master branch:

• 31d9b7f: 8254252: Generic arraycopy stub overwrites callee-save rdi register on 64-bit Windows
• a098037: 8254365: ciMethod.hpp should not include methodHandles.hpp
• d50e0de: 8254722: bsd_zero builds broken after JDK-8253717
• ba5dc67: 8254158: Consolidate per-platform stack overflow handling code
• 715e24a: 8254311: Incorrect statements in createWindowsDevkit2017.sh
• ba24f96: 8251861: Remove unused jdk.internal.ref.SoftCleanable and WeakCleanable
• 6ed4c89: 8254704: Add missing @SInCE tag to BodyPublishers::concat
• 3fb2e82: 8254627: Cleanup {Abstract,Single,Split}IndexWriter classes
• 02d9c29: 8254672: ZGC: ZParallelOopsDo/ZSerialWeakOopsDo should use atomic load/store
• 65393a0: 8229867: Re-examine synchronization usages in http and https protocol handlers
• ... and 25 more: https://git.openjdk.java.net/jdk/compare/54bbe76ed0ce90cea43864da3de7d18a7bbaa196...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9fe9b24.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.