8275712: Hashtable literal_size functions are broken

[stefank]

The literal_size functions are used to estimate the size of held objects in some of our hashtables.

Two bugs:

1. They return int, but the returned value is in bytes and could be larger than MAX_INT.
2. Non-String objects report words instead of bytes.

Manually tested by running JFR and checking the output in JMC.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8275712: Hashtable literal_size functions are broken

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• Zhengyu Gu (@zhengyu123 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6063/head:pull/6063
$ git checkout pull/6063

Update a local copy of the PR:
$ git checkout pull/6063
$ git pull https://git.openjdk.java.net/jdk pull/6063/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6063

View PR using the GUI difftool:
$ git pr show -t 6063

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6063.diff

[bridgekeeper]

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stefank The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0604dac4)

[coleenp]

Looks good.

[openjdk]

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275712: Hashtable literal_size functions are broken

Reviewed-by: coleenp, zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 45ce06c: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST
• 60cb27d: 8275426: PretouchTask num_chunks calculation can overflow
• cd07b3c: 8257534: misc tests failed with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"
• 819d2df: 8274794: Print all owned locks in hs_err file
• c41ce6d: 8275415: Prepare Leak Profiler for Lilliput
• 0c3eaea: 8168388: GetMousePositionTest fails with the message "Mouse position should not be null"
• 09f5235: 8275405: Linking error for classes with lambda template parameters and virtual functions
• a120937: 8274988: G1: refine G1SegmentedArrayAllocOptions and G1CardSetAllocOptions
• c7a80e6: 8275607: G1: G1CardSetAllocator::drop_all needs to call G1SegmentedArray::drop_all
• af7c56b: 8275167: x86 intrinsic for unsignedMultiplyHigh
• ... and 14 more: https://git.openjdk.java.net/jdk/compare/bd0bed71e55f0bb8b4619495c79184f94c0701fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zhengyu123]

LGTM

[stefank]

Thanks for reviewing!
/integrate

[openjdk]

Going to push as commit 1efe946.
Since your change was applied there have been 38 commits pushed to the master branch:

• fab3d6c: 8275761: Backout: JDK-8274794 Print all owned locks in hs_err file
• c978ca8: 8275344: -Xcheck:jni produces some warnings in the LCMS.c
• 6a466fe: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields
• 4e9dd4b: 8275384: Change nested classes in jdk.jconsole to static nested classes
• 0961de4: 8275347: ciReplay: staticfield lines not properly terminated
• 7dd8237: 8275084: CDS warning when building with LOG=debug
• 49f9d80: 8243585: AlgorithmChecker::check throws confusing exception when it rejects the signer key
• bef8cf1: 8275714: G1: remove unused variable in G1Policy::transfer_survivors_to_cset
• af14650: 8275569: Add linux-aarch64 to test-make profiles
• 0761a4b: 8275688: Suppress warnings on non-serializable non-transient instance fields in DualPivotQuicksort
• ... and 28 more: https://git.openjdk.java.net/jdk/compare/bd0bed71e55f0bb8b4619495c79184f94c0701fb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@stefank Pushed as commit 1efe946.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.