-
Notifications
You must be signed in to change notification settings - Fork 6k
8275162: Replace 'def' macros in mutexLocker.cpp #6066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks,
Patricio
Thanks Patricio! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for getting rid of the x-macros when possible. Personally, I'm willing to pay the price of having the name duplication, given how the code becomes easier to understand and more IDE friendly.
@coleenp this pull request can not be integrated into git checkout remove-def
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
This change depended on the change for JDK-8274794 which I'm not going to redo. Will try Ioi's varargs idea. |
This patch removes the 'def' macros from mutexLocker.cpp so it can use the default values for _allow_vm_block when possible and no more macro.
Tested with tier1-3 with product and debug builds.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6066/head:pull/6066
$ git checkout pull/6066
Update a local copy of the PR:
$ git checkout pull/6066
$ git pull https://git.openjdk.java.net/jdk pull/6066/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6066
View PR using the GUI difftool:
$ git pr show -t 6066
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6066.diff