8275872: Sync J2DBench run and analyze Makefile targets with build.xml #6068

judovana · 2021-10-21T17:04:08Z

The run targets of makefile to run J2DBench.jar/J2DAnalyzer.jar were
lacking the dist directory. This patch is fixing it. Note, that
build.xml have correct paths

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8275872: Sync J2DBench run and analyze Makefile targets with build.xml

Reviewers

Magnus Ihse Bursie (@magicus - Reviewer)
Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6068/head:pull/6068
$ git checkout pull/6068

Update a local copy of the PR:
$ git checkout pull/6068
$ git pull https://git.openjdk.java.net/jdk pull/6068/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6068

View PR using the GUI difftool:
$ git pr show -t 6068

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6068.diff

judovana · 2021-10-21T17:04:54Z

I'm looking for kind soul to create bug and merge on my behalf.

bridgekeeper · 2021-10-21T17:15:49Z

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-10-21T17:17:59Z

@judovana The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

judovana · 2021-10-21T17:24:21Z

/label rfr

judovana · 2021-10-21T17:25:04Z

/label add rfr

openjdk · 2021-10-21T17:26:06Z

@judovana The label rfr is not a valid label. These labels are valid:

serviceability
hotspot
hotspot-compiler
ide-support
kulla
i18n
shenandoah
jdk
javadoc
security
hotspot-runtime
jmx
build
nio
client
core-libs
compiler
net
hotspot-gc
hotspot-jfr

openjdk · 2021-10-21T17:26:24Z

@judovana The label rfr is not a valid label. These labels are valid:

serviceability
hotspot
hotspot-compiler
ide-support
kulla
i18n
shenandoah
jdk
javadoc
security
hotspot-runtime
jmx
build
nio
client
core-libs
compiler
net
hotspot-gc
hotspot-jfr

magicus · 2021-10-21T23:32:19Z

/label build

magicus · 2021-10-21T23:32:40Z

Hi @judovana

This PR is not going to be noticed by anyone who can review it. Please send an email to the relevant mailing lists (in this case client-dev@openjdk.java.net and build-dev@openjdk.java.net) to raise a discussion and, hopefully, have someone sponsor this PR.

openjdk · 2021-10-21T23:32:57Z

@magicus
The build label was successfully added.

mrserb · 2021-10-23T01:50:40Z

this looks fine, please update the copyright date

gnu-andrew · 2021-10-25T14:18:32Z

I've filed https://bugs.openjdk.java.net/browse/JDK-8275872 and am happy to sponsor this minor change.
@judovana, please update the summary with the bug ID. Thanks.

gnu-andrew · 2021-10-25T14:19:53Z

/summary 8275872: Sync J2DBench run and analyze Makefile targets with build.xml

openjdk · 2021-10-25T14:21:14Z

@gnu-andrew Only the author (@judovana) is allowed to issue the /summary command.

judovana · 2021-10-25T16:07:40Z

/summary 8275872: Sync J2DBench run and analyze Makefile targets with build.xml

openjdk · 2021-10-25T16:08:03Z

@judovana Setting summary to 8275872: Sync J2DBench run and analyze Makefile targets with build.xml

judovana · 2021-10-25T16:08:12Z

@mrserb @gnu-andrew hi! Thanx! The PR was amended.

mlbridge · 2021-10-25T16:13:19Z

Webrevs

01: Full - Incremental (811f18d8)
00: Full (e28f550b)

mrserb · 2021-10-25T23:11:01Z

src/demo/share/java2d/J2DBench/Makefile

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved.
+# Copyright (c) 2002, 2020, 2021 Oracle and/or its affiliates. All rights reserved.


You need to update the second date, no need to create an additional one.
The first date is when the file was created and the second is when it was updated last time.

Oh damn. Sorry. Fixed

Fixed path for run of J2DBench.jar and J2DAnalyzer.jar The run targets of makefile to run J2DBench.jar/J2DAnalyzer.jar were lacking the dist directory. This patch is fixing it. Note, that build.xml have correct paths

openjdk · 2021-10-26T08:20:22Z

@judovana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275872: Sync J2DBench run and analyze Makefile targets with build.xml

Reviewed-by: ihse, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

19f76c2: 8275079: Remove unnecessary conversion to String in java.net.http
e5cd269: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info
82f4aac: 8259609: C2: optimize long range checks in long counted loops
574f890: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak
7c88a59: 8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:]
c9dec2f: 8273299: Unnecessary Vector usage in java.security.jgss
b98ed55: 8275819: [TableRowAccessibility accessibilityChildren] method is ineffective
71d593e: 8275162: Use varargs in 'def' macros in mutexLocker.cpp
7ca053d: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR
4be88d5: 8275047: Optimize existing fill stubs for AVX-512 target
... and 35 more: https://git.openjdk.java.net/jdk/compare/bef8cf1ba14d3846977942844f341f5c5a1f44c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@magicus, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

magicus · 2021-10-26T10:50:53Z

@judovana Unfortunately you got "tricked" by @gnu-andrew 's comment into issuing a /summary comment, when you shouldn't have. That only makes the bug title be repeated as a summary. This is not how summaries are intented. (In fact, they are hardly used at all in the JDK project, and only to shortly describe the fix if the bug title is not descriptive enough).

I'm not sure if you can remove a summary, but I think you can by just issuing a blank /summary command, without any contents.

magicus · 2021-10-26T10:51:23Z

I can sponsor the PR once this is done.

judovana · 2021-10-26T11:10:03Z

/summary

openjdk · 2021-10-26T11:10:59Z

@judovana Removing existing summary

judovana · 2021-10-26T11:13:19Z

Attmept done. Looks like the summary is there already once. Thanx again.

dholmes-ora · 2021-10-26T12:27:57Z

@judovana please do not use "force push" in a PR as it makes the review process very difficult and can leave orphaned comments. You can simply push additional changes after the initial commit. The skara tooling with flatten all commits into one single, properly formulated, commit that will actually be pushed to the OpenJDK repo. Thanks.

magicus · 2021-10-26T12:29:58Z

/sponsor

openjdk · 2021-10-26T12:31:17Z

@magicus The change author (@judovana) must issue an integrate command before the integration can be sponsored.

judovana · 2021-10-26T12:32:15Z

thanx @dholmes-ora , will do

judovana · 2021-10-26T12:32:28Z

/integrate

openjdk · 2021-10-26T12:33:59Z

@judovana
Your change (at version 811f18d) is now ready to be sponsored by a Committer.

magicus · 2021-10-26T12:43:31Z

/sponsor

openjdk · 2021-10-26T16:55:12Z

Going to push as commit f1f5e26.
Since your change was applied there have been 45 commits pushed to the master branch:

19f76c2: 8275079: Remove unnecessary conversion to String in java.net.http
e5cd269: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info
82f4aac: 8259609: C2: optimize long range checks in long counted loops
574f890: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak
7c88a59: 8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:]
c9dec2f: 8273299: Unnecessary Vector usage in java.security.jgss
b98ed55: 8275819: [TableRowAccessibility accessibilityChildren] method is ineffective
71d593e: 8275162: Use varargs in 'def' macros in mutexLocker.cpp
7ca053d: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR
4be88d5: 8275047: Optimize existing fill stubs for AVX-512 target
... and 35 more: https://git.openjdk.java.net/jdk/compare/bef8cf1ba14d3846977942844f341f5c5a1f44c4...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-10-26T16:55:30Z

@magicus @judovana Pushed as commit f1f5e26.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the client label Oct 21, 2021

openjdk bot added the build label Oct 21, 2021

judovana force-pushed the j2dbenchBadRuntimeArtifacts branch from 63ba355 to e28f550 Compare Oct 25, 2021

judovana changed the title ~~Fixed path for run of J2DBench.jar and J2DAnalyzer.jar~~ 8275872: Sync J2DBench run and analyze Makefile targets with build.xml Oct 25, 2021

openjdk bot added the rfr label Oct 25, 2021

mrserb reviewed Oct 25, 2021

View changes

judovana force-pushed the j2dbenchBadRuntimeArtifacts branch from e28f550 to 811f18d Compare Oct 26, 2021

magicus approved these changes Oct 26, 2021

View changes

openjdk bot added the ready label Oct 26, 2021

openjdk bot added the sponsor label Oct 26, 2021

gnu-andrew approved these changes Oct 26, 2021

View changes

openjdk bot closed this Oct 26, 2021

openjdk bot added integrated and removed ready rfr sponsor labels Oct 26, 2021

openjdk / jdk Public

8275872: Sync J2DBench run and analyze Makefile targets with build.xml #6068

8275872: Sync J2DBench run and analyze Makefile targets with build.xml #6068

judovana commented Oct 21, 2021 •

edited by openjdk[bot] bot

judovana commented Oct 21, 2021

bridgekeeper bot commented Oct 21, 2021

openjdk bot commented Oct 21, 2021

judovana commented Oct 21, 2021

judovana commented Oct 21, 2021

openjdk bot commented Oct 21, 2021

openjdk bot commented Oct 21, 2021

magicus commented Oct 21, 2021

magicus commented Oct 21, 2021

openjdk bot commented Oct 21, 2021

mrserb commented Oct 23, 2021

gnu-andrew commented Oct 25, 2021

gnu-andrew commented Oct 25, 2021

openjdk bot commented Oct 25, 2021

judovana commented Oct 25, 2021

openjdk bot commented Oct 25, 2021

judovana commented Oct 25, 2021

mlbridge bot commented Oct 25, 2021 •

edited

mrserb Oct 25, 2021

judovana Oct 26, 2021

openjdk bot commented Oct 26, 2021 •

edited

magicus commented Oct 26, 2021

magicus commented Oct 26, 2021

judovana commented Oct 26, 2021

openjdk bot commented Oct 26, 2021

judovana commented Oct 26, 2021

dholmes-ora commented Oct 26, 2021

magicus commented Oct 26, 2021

openjdk bot commented Oct 26, 2021

judovana commented Oct 26, 2021

judovana commented Oct 26, 2021

openjdk bot commented Oct 26, 2021

magicus commented Oct 26, 2021

openjdk bot commented Oct 26, 2021

openjdk bot commented Oct 26, 2021

openjdk / jdk Public

8275872: Sync J2DBench run and analyze Makefile targets with build.xml #6068

8275872: Sync J2DBench run and analyze Makefile targets with build.xml #6068

Conversation

judovana commented Oct 21, 2021 • edited by openjdk[bot] bot

Progress

Issue

Reviewers

Reviewing

judovana commented Oct 21, 2021

bridgekeeper bot commented Oct 21, 2021

openjdk bot commented Oct 21, 2021

judovana commented Oct 21, 2021

judovana commented Oct 21, 2021

openjdk bot commented Oct 21, 2021

openjdk bot commented Oct 21, 2021

magicus commented Oct 21, 2021

magicus commented Oct 21, 2021

openjdk bot commented Oct 21, 2021

mrserb commented Oct 23, 2021

gnu-andrew commented Oct 25, 2021

gnu-andrew commented Oct 25, 2021

openjdk bot commented Oct 25, 2021

judovana commented Oct 25, 2021

openjdk bot commented Oct 25, 2021

judovana commented Oct 25, 2021

mlbridge bot commented Oct 25, 2021 • edited

Webrevs

mrserb Oct 25, 2021

Choose a reason for hiding this comment

judovana Oct 26, 2021

Choose a reason for hiding this comment

openjdk bot commented Oct 26, 2021 • edited

magicus commented Oct 26, 2021

magicus commented Oct 26, 2021

judovana commented Oct 26, 2021

openjdk bot commented Oct 26, 2021

judovana commented Oct 26, 2021

dholmes-ora commented Oct 26, 2021

magicus commented Oct 26, 2021

openjdk bot commented Oct 26, 2021

judovana commented Oct 26, 2021

judovana commented Oct 26, 2021

openjdk bot commented Oct 26, 2021

magicus commented Oct 26, 2021

openjdk bot commented Oct 26, 2021

openjdk bot commented Oct 26, 2021

judovana commented Oct 21, 2021 •

edited by openjdk[bot] bot

mlbridge bot commented Oct 25, 2021 •

edited

openjdk bot commented Oct 26, 2021 •

edited