8252407: Build failure with gcc-8+ and asan

[e1iu]

Summary: Fix stringop-truncation warnings casused by gcc.

The newer gcc(gcc-8 or higher) would warn for calls to bounded string
manipulation functions such as 'strncpy' that may either truncate the
copied string or leave the destination unchanged.

The reason is that -fsanitize=address might simply incompatible with
-Wstringop-truncation. This patch disables stringop-truncation warning
when asan enabled, also disables the defining of _FORTIFY_SOURCE in
fastdebug builds for some potential risks.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8252407: Build failure with gcc-8+ and asan

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer)
• Kim Barrett (@kimbarrett - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/607/head:pull/607
$ git checkout pull/607

[bridgekeeper]

👋 Welcome back erik1iu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@erik1iu The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e5cec6e)

[e1iu]

Previous discussion https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-September/042810.html

[magicus]

Looks good to me.

It's slightly unsettling that we enable fortify silently under very special circumstances, but while the circumstances change with the bug, the behavior as such do not, so I don't think this is the place to make it more visible and/or controllable.

[kimbarrett]

Looks good to me. This is what I was expecting to see, based on the previous discussion.

[e1iu]

Thank Kim and Magnus for reviews.

[e1iu]

/integrate

[openjdk]

@erik1iu This PR has not yet been marked as ready for integration.

[openjdk]

⚠️ @erik1iu the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout warning-fix
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@erik1iu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252407: Build failure with gcc-8+ and asan

Reviewed-by: ihse, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 428 new commits pushed to the master branch:

• 2a4328b: 8254610: Problem list test compiler/debug/TestStressCM.java
• bff586f: 8254269: simplify Node::disconnect_inputs
• d7128e7: 8254090: Collectors.toUnmodifiableList exposes shared secret
• df1f132: 8253563: Change sun.security.jca.Providers.threadLists to be ThreadLocal
• c7f0064: 8253899: Make IsClassUnloadingEnabled signature match specification
• aad3cf4: 8254234: Add test library stream object builder
• 4184959: 8252374: Add a new factory method to concatenate a sequence of BodyPublisher instances into a single publisher.
• 05459df: 8253765: C2: Control randomization in StressLCM and StressGCM
• 6620b61: 8254573: Shenandoah: Streamline/inline native-LRB entry point
• a6c23b7: 8253923: C2 doesn't always run loop opts for compilations that include loops
• ... and 418 more: https://git.openjdk.java.net/jdk/compare/30fa8d5d341fbf64e84da13a05c8048afba25196...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@magicus, @kimbarrett) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[e1iu]

/integrate

[openjdk]

@erik1iu
Your change (at version e5cec6e) is now ready to be sponsored by a Committer.

[nick-arm]

/sponsor

[openjdk]

@nick-arm @erik1iu Since your change was applied there have been 428 commits pushed to the master branch:

• 2a4328b: 8254610: Problem list test compiler/debug/TestStressCM.java
• bff586f: 8254269: simplify Node::disconnect_inputs
• d7128e7: 8254090: Collectors.toUnmodifiableList exposes shared secret
• df1f132: 8253563: Change sun.security.jca.Providers.threadLists to be ThreadLocal
• c7f0064: 8253899: Make IsClassUnloadingEnabled signature match specification
• aad3cf4: 8254234: Add test library stream object builder
• 4184959: 8252374: Add a new factory method to concatenate a sequence of BodyPublisher instances into a single publisher.
• 05459df: 8253765: C2: Control randomization in StressLCM and StressGCM
• 6620b61: 8254573: Shenandoah: Streamline/inline native-LRB entry point
• a6c23b7: 8253923: C2 doesn't always run loop opts for compilations that include loops
• ... and 418 more: https://git.openjdk.java.net/jdk/compare/30fa8d5d341fbf64e84da13a05c8048afba25196...master

Your commit was automatically rebased without conflicts.

Pushed as commit b464213.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.