Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8275775: VM.metaspace prints flag 'f' for classes that have non-trivial finalize() #6075

Closed
wants to merge 5 commits into from
+5 −6
Closed

8275775: VM.metaspace prints flag 'f' for classes that have non-trivial finalize() #6075

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8055958
8275775 VM.metaspace prints flag 'f' for classes that overrided final…
kelthuzadx Oct 22, 2021
bf37d1b
8275775 VM.metaspace prints flag 'f' for classes that overrided final…
kelthuzadx Oct 22, 2021
817fb08
use has-nontrivial-finalize
kelthuzadx Oct 26, 2021
51c959b
Merge branch 'ms_report' of https://github.com/kelthuzadx/jdk into ms…
kelthuzadx Oct 26, 2021
7bbf151
typo
kelthuzadx Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 src/hotspot/share/memory/metaspace/printCLDMetaspaceInfoClosure.cpp
View file
Open in desktop
@@ -147,9 +147,7 @@ void PrintCLDMetaspaceInfoClosure::do_cld(ClassLoaderData* cld) {
streamIndentor sti(_out, 6);
_out->cr_indent();
_out->print("Loaded classes");
if (ckc._num_classes_shared > 0) {
_out->print("('s' = shared)");
}
_out->print("('s' = shared, 'f' = has_nontrivial_finalize)");
_out->print(":");
PrintMetaspaceInfoKlassClosure pkic(_out, true);
cld->classes_do(&pkic);
7 src/hotspot/share/memory/metaspace/printMetaspaceInfoKlassClosure.cpp
View file
Open in desktop
@@ -42,11 +42,12 @@ void PrintMetaspaceInfoKlassClosure::do_klass(Klass* k) {
_out->print(UINTX_FORMAT_W(4) ": ", _cnt);

// Print a 's' for shared classes
_out->put(k->is_shared() ? 's': ' ');
_out->put(k->is_shared() ? 's' : ' ');
// Print a 'f' for classes that have an non-trivial finalize() method
_out->put(k->has_finalizer() ? 'f' : ' ');

ResourceMark rm;
_out->print(" %s", k->external_name());

_out->print(" %s (" INTPTR_FORMAT ")", k->external_name(), p2i(k));
Copy link
Member

@dholmes-ora dholmes-ora Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the address printed?

Copy link
Member Author

@kelthuzadx kelthuzadx Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this would facilitate further debugging. I will remove them if you think they are not necessary.

Copy link
Member

@tstuefe tstuefe Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove it. Its not needed in this context.

// Special treatment for generated core reflection accessor classes: print invocation target.
if (ReflectionAccessorImplKlassHelper::is_generated_accessor(k)) {
_out->print(" (invokes: ");