New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8275775: VM.metaspace prints flag 'f' for classes that have non-trivial finalize() #6075
Changes from 3 commits
8055958
bf37d1b
817fb08
51c959b
7bbf151
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
@@ -43,8 +43,8 @@ void PrintMetaspaceInfoKlassClosure::do_klass(Klass* k) { | ||
|
||
// Print a 's' for shared classes | ||
_out->put(k->is_shared() ? 's' : ' '); | ||
// Print 's' for classes that overrided finalize() method | ||
_out->put(k->has_finalizer() ?'f' : ' '); | ||
// Print a 'f' for classes that having a non-trivial finalize() method | ||
_out->put(k->has_finalizer() ? 'f' : ' '); | ||
|
||
ResourceMark rm; | ||
_out->print(" %s (" INTPTR_FORMAT ")", k->external_name(), p2i(k)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need the address printed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess this would facilitate further debugging. I will remove them if you think they are not necessary. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please remove it. Its not needed in this context. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/a/an/ (as 'f' is pronounced eff it gets treated as a vowel)
s/having/have/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops.. Good catch!