Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274734: the method jdk.jshell.SourceCodeAnalysis documentation not working #6080

Closed
wants to merge 1 commit into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Oct 22, 2021

The SourceCodeAnalysisImpl needs to open src.zip to read the sources to get javadoc. Unfortunately, it uses the variant of the newFileSystem method that can only be used one, and hence only one SourceCodeAnalysisImpl can provide documentation. The proposed solution is to use the variant of the newFileSystem method that can open the FileSystem multiple times, so that multiple independent SourceCodeAnalysisImpl instances can provide documentation.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274734: the method jdk.jshell.SourceCodeAnalysis documentation not working

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6080/head:pull/6080
$ git checkout pull/6080

Update a local copy of the PR:
$ git checkout pull/6080
$ git pull https://git.openjdk.java.net/jdk pull/6080/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6080

View PR using the GUI difftool:
$ git pr show -t 6080

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6080.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 22, 2021

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2021

@lahodaj The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla label Oct 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 22, 2021

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

looks sensible

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274734: the method jdk.jshell.SourceCodeAnalysis documentation not working

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 179 new commits pushed to the master branch:

  • c393ee8: 8276632: Use blessed modifier order in security-libs code
  • 7023b3f: 8276628: Use blessed modifier order in serviceability code
  • b933136: 8276641: Use blessed modifier order in jshell
  • 0616d86: 8276635: Use blessed modifier order in compiler code
  • d95299a: 8276634: Remove usePlainDatagramSocketImpl option from the test DatagramChannel/SendReceiveMaxSize.java
  • 3c0faa7: 8276173: Clean up and remove unneeded casts in HeapDumper
  • 323d201: 8275506: Rename allocated_on_stack to allocated_on_stack_or_embedded
  • 96c396b: 8276151: AArch64: Incorrect result for double to int vector conversion
  • 7281861: 8272065: jcmd cannot rely on the old core reflection implementation which will be changed after JEP 416
  • 8e17ce0: 8275185: Remove dead code and clean up jvmstat LocalVmManager
  • ... and 169 more: https://git.openjdk.java.net/jdk/compare/1efe946db77e38507511a9c898b8b59fe9ba1aeb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 5, 2021
@lahodaj
Copy link
Contributor Author

@lahodaj lahodaj commented Nov 8, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 8, 2021

Going to push as commit 4c14edd.
Since your change was applied there have been 196 commits pushed to the master branch:

  • ff6863c: 8276540: Howl Full CardSet container iteration marks too many cards
  • 5448139: 8271056: C2: "assert(no_dead_loop) failed: dead loop detected" due to cmoving identity
  • 0395e4e: 8276768: Snippet copy feature should use button instead of link
  • d8b0dee: 8276239: Better tables in java.util.random package summary
  • fc0fe25: 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit
  • 3934fe5: 8275847: Scheduling fails with "too many D-U pinch points" on small method
  • 44047f8: 8274328: C2: Redundant CFG edges fixup in block ordering
  • 8849154: 8275846: read_base_archive_name() could read past the end of buffer
  • 2653cfb: 8276688: Remove JLinkReproducibleXXXTest from ProblemList.txt
  • c7095b2: 8276207: Properties.loadFromXML/storeToXML works incorrectly for supplementary characters
  • ... and 186 more: https://git.openjdk.java.net/jdk/compare/1efe946db77e38507511a9c898b8b59fe9ba1aeb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 8, 2021

@lahodaj Pushed as commit 4c14edd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated kulla
2 participants