Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:] #6083

wants to merge 1 commit into from


Copy link

@forantar forantar commented Oct 22, 2021

Adding a JNI weak ref check. There's a couple of other similar places in the code where a JNI weak ref is checked for null, in the rest of the code we pass such refs to java where they are checked for null. So, I was not able to eye catch any other similar place in the a11y code where such check is also required.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


  • JDK-8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:]



Using git

Checkout this PR locally:
$ git fetch pull/6083/head:pull/6083
$ git checkout pull/6083

Update a local copy of the PR:
$ git checkout pull/6083
$ git pull pull/6083/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6083

View PR using the GUI difftool:
$ git pr show -t 6083

Using diff file

Download this PR as a diff file:

Copy link

bridgekeeper bot commented Oct 22, 2021

👋 Welcome back ant! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 22, 2021
Copy link

openjdk bot commented Oct 22, 2021

@forantar The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Oct 22, 2021
Copy link

mlbridge bot commented Oct 22, 2021


Copy link

victordyakov commented Oct 22, 2021

@azuev-java @pankaj-bansal please review

Copy link

openjdk bot commented Oct 25, 2021

@forantar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:]

Reviewed-by: kizune, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 89671aa: 8273712: C2: Add mechanism for rejecting inlining of low frequency call sites and deprecate MinInliningThreshold.
  • 3221a14: 8273678: TableAccessibility and TableRowAccessibility miss autorelease
  • 7cf68b1: 8202932: java/awt/Component/NativeInLightShow/ fails
  • f610ef0: 8196440: Regression automated Test 'java/awt/TrayIcon/PopupMenuLeakTest/' fails
  • f143d2a: 8268595: java/io/Serializable/serialFilter/ failed in timeout
  • 7f94302: 8275511: G1: Rename needs_remset_update to remset_is_tracked in G1HeapRegionAttr
  • 0bcc174: 8275717: Reimplement STATIC_ASSERT to use static_assert
  • f623298: 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key
  • 1da5e6b: 8275104: IR framework does not handle client VM builds correctly
  • 5dab76b: 8275381: G1: refactor 2 constructors of G1CardSetConfiguration
  • ... and 6 more:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 25, 2021
Copy link

@pankaj-bansal pankaj-bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor Author


Copy link

openjdk bot commented Oct 26, 2021

Going to push as commit 7c88a59.
Since your change was applied there have been 29 commits pushed to the master branch:

  • c9dec2f: 8273299: Unnecessary Vector usage in
  • b98ed55: 8275819: [TableRowAccessibility accessibilityChildren] method is ineffective
  • 71d593e: 8275162: Use varargs in 'def' macros in mutexLocker.cpp
  • 7ca053d: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/ fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR
  • 4be88d5: 8275047: Optimize existing fill stubs for AVX-512 target
  • 63e0f34: 8275767: JDK source code contains redundant boolean operations in jdk.charsets
  • 4961373: 8275137: jdk.unsupported/sun.reflect.ReflectionFactory.readObjectNoDataForSerialization uses wrong signature
  • 174f553: 8275869: Problem list applications/jcstress/ on Linux-aarch64
  • 3ff085e: 8275582: Don't purge metaspace mapping lists
  • 10e1610: 8251134: Unwrapping a key with a Private Key generated by Microsoft CNG fails
  • ... and 19 more:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 26, 2021
Copy link

openjdk bot commented Oct 26, 2021

@forantar Pushed as commit 7c88a59.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
client integrated Pull request has been integrated
4 participants