Skip to content

8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time#6087

Closed
prrace wants to merge 1 commit intoopenjdk:masterfrom
prrace:inf_xform_test
Closed

8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time#6087
prrace wants to merge 1 commit intoopenjdk:masterfrom
prrace:inf_xform_test

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Oct 22, 2021

This test has only failed once - for reasons that are not clear.
I wanted to just increase the timeout but the test was written such that it always waited as long
as the timeout since it had an un-canceled scheduled task.

So I've also made the test cancel the task once it is complete and made the variables volatile
so that they should be read properly by the other thread.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6087/head:pull/6087
$ git checkout pull/6087

Update a local copy of the PR:
$ git checkout pull/6087
$ git pull https://git.openjdk.java.net/jdk pull/6087/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6087

View PR using the GUI difftool:
$ git pr show -t 6087

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6087.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 22, 2021
@openjdk
Copy link

openjdk bot commented Oct 22, 2021

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 22, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 22, 2021

Webrevs

@mrserb
Copy link
Member

mrserb commented Oct 23, 2021

Why do we need all that TimerTask machinery? We can just place the code to the main method, and the jtreg will provide useful information on the timeout if any.

@prrace
Copy link
Contributor Author

prrace commented Oct 24, 2021

The test is just being minimally updated for stability.
If you want to re-write it under a follow up PR - you may do so, but I'm just stabilising what is there

Copy link
Member

@mrserb mrserb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, looks fine then

@openjdk
Copy link

openjdk bot commented Oct 24, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time

Reviewed-by: serb, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 5dab76b: 8275381: G1: refactor 2 constructors of G1CardSetConfiguration
  • 5bbe4ca: 8275293: A change done with JDK-8268764 mismatches the java.rmi.server.ObjID.hashCode spec
  • c94dc2a: 8272854: split runtime/CommandLine/PrintTouchedMethods.java test
  • fec470f: 8272163: Add -version option to keytool and jarsigner

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 24, 2021
Copy link
Contributor

@prsadhuk prsadhuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably you can consider rectifying the wild card imports also...

@prrace
Copy link
Contributor Author

prrace commented Nov 2, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 2, 2021

Going to push as commit acceffc.
Since your change was applied there have been 101 commits pushed to the master branch:

  • 2eafa03: 8276234: Trivially clean up locale-related code
  • 47e7a42: 8262945: [macos] Regression Manual Test for Key Events Fails
  • 99b7b95: 8276205: Shenandoah: CodeCache_lock should always be held for initializing code cache iteration
  • 9771544: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations
  • e265f83: 8276107: Preventive collections trigger before maxing out heap
  • c8abe35: 8276121: G1: Remove unused and uninitialized _g1h in g1SATBMarkQueueSet.hpp
  • f55e68c: 8275950: Use only _thread_in_vm in ~ThreadBlockInVMPreprocess()
  • 4ac8403: 8276218: JFR: Clean up jdk.jfr.dcmd
  • 89ade1d: 8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}
  • dbf5100: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
  • ... and 91 more: https://git.openjdk.java.net/jdk/compare/6523c558d92dedf350576126960dee6cff8f6067...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

@prrace Pushed as commit acceffc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants