8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time#6087
8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time#6087prrace wants to merge 1 commit intoopenjdk:masterfrom
Conversation
…finiteXform transform takes long time
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
Why do we need all that TimerTask machinery? We can just place the code to the main method, and the jtreg will provide useful information on the timeout if any. |
|
The test is just being minimally updated for stability. |
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
prsadhuk
left a comment
There was a problem hiding this comment.
Probably you can consider rectifying the wild card imports also...
|
/integrate |
|
Going to push as commit acceffc.
Your commit was automatically rebased without conflicts. |
This test has only failed once - for reasons that are not clear.
I wanted to just increase the timeout but the test was written such that it always waited as long
as the timeout since it had an un-canceled scheduled task.
So I've also made the test cancel the task once it is complete and made the variables volatile
so that they should be read properly by the other thread.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6087/head:pull/6087$ git checkout pull/6087Update a local copy of the PR:
$ git checkout pull/6087$ git pull https://git.openjdk.java.net/jdk pull/6087/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6087View PR using the GUI difftool:
$ git pr show -t 6087Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6087.diff