Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276042: Remove unused local variables in java.naming #6091

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Oct 23, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276042: Remove unused local variables in java.naming

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6091/head:pull/6091
$ git checkout pull/6091

Update a local copy of the PR:
$ git checkout pull/6091
$ git pull https://git.openjdk.java.net/jdk pull/6091/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6091

View PR using the GUI difftool:
$ git pr show -t 6091

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6091.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 23, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Oct 23, 2021
@turbanoff turbanoff changed the title [PATCH] Remove unused local variable in java.naming 8276042: Remove unused local variables in java.naming Oct 27, 2021
@openjdk openjdk bot added the rfr label Oct 27, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 27, 2021

Webrevs

Copy link
Member

@AlekseiEfimov AlekseiEfimov left a comment

Hi Andrey,

Thanks for cleaning up the code.
Changes look good to me, with one suggestion below.

dfuch
dfuch approved these changes Oct 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276042: Remove unused local variables in java.naming

Reviewed-by: aefimov, dfuchs, vtewari

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

  • 1750a6e: 8276055: ZGC: Defragment address space
  • d9b0138: 8275704: Metaspace::contains() should be threadsafe
  • 9a3e954: 8274879: Replace uses of StringBuffer with StringBuilder within java.base classes
  • e6fa5fa: 8276063: ProblemList gtest dll_address_to_function_and_library_name on macosx-generic
  • 809488b: 8276046: codestrings.validate_vm gtest fails on ppc64, s390
  • 93be099: 4718400: Many quantities are held as signed that should be unsigned
  • 168081e: 8270490: Charset.forName() taking fallback default value
  • a292733: 8275975: Remove dead code in ciInstanceKlass
  • 4060602: 8275800: Redefinition leaks MethodData::_extra_data_lock
  • 485d658: 8275851: Deproblemlist open/test/jdk/javax/swing/JComponent/6683775/bug6683775.java
  • ... and 39 more: https://git.openjdk.java.net/jdk/compare/c94dc2ab60f0548afa868e41a0b87a68030e0cac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlekseiEfimov, @dfuch, @vyommani) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 27, 2021
Copy link
Contributor

@vyommani vyommani left a comment

Looks good to me.

@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Oct 28, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@turbanoff
Your change (at version f697d88) is now ready to be sponsored by a Committer.

@AlekseiEfimov
Copy link
Member

@AlekseiEfimov AlekseiEfimov commented Oct 28, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

Going to push as commit 593401f.
Since your change was applied there have been 50 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@AlekseiEfimov @turbanoff Pushed as commit 593401f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
4 participants