Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275851: Deproblemlist open/test/jdk/javax/swing/JComponent/6683775/bug6683775.java #6097

Closed
wants to merge 3 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Oct 25, 2021

Test was problemlisted long time back by JDK-8193211 but it is passing now..Modified testFrame access in EDT and dispose in finally block for better safeguard. Problemlisted test was marked for 8u so did not close it..
Several iterations of the test pass in all platforms in mainline..


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275851: Deproblemlist open/test/jdk/javax/swing/JComponent/6683775/bug6683775.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6097/head:pull/6097
$ git checkout pull/6097

Update a local copy of the PR:
$ git checkout pull/6097
$ git pull https://git.openjdk.java.net/jdk pull/6097/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6097

View PR using the GUI difftool:
$ git pr show -t 6097

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6097.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 25, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Oct 25, 2021
@openjdk openjdk bot added the rfr label Oct 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 25, 2021

Webrevs

mrserb
mrserb approved these changes Oct 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275851: Deproblemlist open/test/jdk/javax/swing/JComponent/6683775/bug6683775.java

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

  • 6c05cc9: 8275863: Use encodeASCII for ASCII-compatible DoubleByte encodings
  • 2f979ec: 8213120: java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java fails on mac10.13
  • 9e831bc: 8275886: G1: remove obsolete comment in HeapRegion::setup_heap_region_size
  • 9f75d5c: 8259948: Aarch64: Add cast nodes for Aarch64 Neon backend
  • d98b7c2: 8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails
  • b0d1e4f: 8273585: String.charAt performance degrades due to JDK-8268698
  • 7addcd7: 8276034: ProblemList gtest dll_address_to_function_and_library_name on macosx-x64
  • 2448b3f: 8275874: [JVMCI] only support aligned reads in c2v_readFieldValue
  • f1f5e26: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml
  • 19f76c2: 8275079: Remove unnecessary conversion to String in java.net.http
  • ... and 75 more: https://git.openjdk.java.net/jdk/compare/bd0bed71e55f0bb8b4619495c79184f94c0701fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 27, 2021
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Oct 27, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

Going to push as commit 485d658.
Since your change was applied there have been 86 commits pushed to the master branch:

  • b3f45f8: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test
  • 6c05cc9: 8275863: Use encodeASCII for ASCII-compatible DoubleByte encodings
  • 2f979ec: 8213120: java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java fails on mac10.13
  • 9e831bc: 8275886: G1: remove obsolete comment in HeapRegion::setup_heap_region_size
  • 9f75d5c: 8259948: Aarch64: Add cast nodes for Aarch64 Neon backend
  • d98b7c2: 8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails
  • b0d1e4f: 8273585: String.charAt performance degrades due to JDK-8268698
  • 7addcd7: 8276034: ProblemList gtest dll_address_to_function_and_library_name on macosx-x64
  • 2448b3f: 8275874: [JVMCI] only support aligned reads in c2v_readFieldValue
  • f1f5e26: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml
  • ... and 76 more: https://git.openjdk.java.net/jdk/compare/bd0bed71e55f0bb8b4619495c79184f94c0701fb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

@prsadhuk Pushed as commit 485d658.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8275851 branch Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated
2 participants