Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8275856: Remove MetaspaceHandleDeallocations debug switch #6098

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Oct 25, 2021

MetaspaceHandleDeallocations can be used to switch off deallocation handling (which takes care of reusing prematurely deallocated metaspace blocks in case of e.g. class redefinitions or class loading errors). Technically this is a leak then, the intent was to switch off the deallocation handling for error analysis.

It had been very rarely used, only in the first stages of JEP 387, and it is not covered by tests. I propose to remove it to reduce code complexity.

Tests: GHAs, manual tests (note that we have regression tests in place for deallocation handling), SAP nightlies


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275856: Remove MetaspaceHandleDeallocations debug switch

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6098/head:pull/6098
$ git checkout pull/6098

Update a local copy of the PR:
$ git checkout pull/6098
$ git pull https://git.openjdk.java.net/jdk pull/6098/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6098

View PR using the GUI difftool:
$ git pr show -t 6098

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6098.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 25, 2021

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Oct 25, 2021
@tstuefe tstuefe marked this pull request as ready for review Oct 27, 2021
@openjdk openjdk bot added the rfr label Oct 27, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 27, 2021

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275856: Remove MetaspaceHandleDeallocations debug switch

Reviewed-by: coleenp, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

  • c9e65f8: 8275440: Remove VirtualSpaceList::is_full()
  • de93b1d: 8257722: Improve "keytool -printcert -jarfile" output
  • 21da218: 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior
  • 48f3fca: 8275308: Add valueOf(Runtime.Version) factory to SourceVersion
  • c6339cb: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle
  • 5a768f7: 8276054: JMH benchmarks for Fences
  • 6d8fa8f: 8255286: Implement ParametersTypeData::print_data_on fully
  • 63b9f8c: 8153490: Cannot setBytes() if incoming buffer's length is bigger than number of elements we want to insert.
  • cb989cf: 8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks
  • c92f230: 8276110: Problemlist javax/swing/JMenu/4515762/bug4515762.java for macos12
  • ... and 58 more: https://git.openjdk.java.net/jdk/compare/c94dc2ab60f0548afa868e41a0b87a68030e0cac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 27, 2021
iklam
iklam approved these changes Oct 29, 2021
Copy link
Member

@iklam iklam left a comment

LGTM

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Oct 29, 2021

Thanks Ioi and Coleen!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2021

Going to push as commit 157e1d5.
Since your change was applied there have been 68 commits pushed to the master branch:

  • c9e65f8: 8275440: Remove VirtualSpaceList::is_full()
  • de93b1d: 8257722: Improve "keytool -printcert -jarfile" output
  • 21da218: 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior
  • 48f3fca: 8275308: Add valueOf(Runtime.Version) factory to SourceVersion
  • c6339cb: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle
  • 5a768f7: 8276054: JMH benchmarks for Fences
  • 6d8fa8f: 8255286: Implement ParametersTypeData::print_data_on fully
  • 63b9f8c: 8153490: Cannot setBytes() if incoming buffer's length is bigger than number of elements we want to insert.
  • cb989cf: 8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks
  • c92f230: 8276110: Problemlist javax/swing/JMenu/4515762/bug4515762.java for macos12
  • ... and 58 more: https://git.openjdk.java.net/jdk/compare/c94dc2ab60f0548afa868e41a0b87a68030e0cac...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2021

@tstuefe Pushed as commit 157e1d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tstuefe tstuefe deleted the JDK-8275856-remove-metaspacehandledeallocations branch Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
3 participants