New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer #610
Conversation
|
@pconcannon The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsExchange.java
Show resolved
Hide resolved
src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsServer.java
Show resolved
Hide resolved
src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsServer.java
Show resolved
Hide resolved
src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsServer.java
Outdated
Show resolved
Hide resolved
src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsServer.java
Show resolved
Hide resolved
This is a JDK specific API - but since you're updating (filling out) some API doc comments that were previously empty I suspect a CSR will still be needed. |
@dfuch has indicated that a compatibility and specification (CSR) request is needed for this pull request. |
src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsParameters.java
Show resolved
Hide resolved
src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsParameters.java
Show resolved
Hide resolved
@pconcannon This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 42 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
@pconcannon Since your change was applied there have been 49 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit da97ab5. |
Hi,
Could someone please review my doc-only fix for JDK-8253474: 'Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer' ?
This fix is set of formatting changes intended to clean up the javadoc of the following classes :
com.sun.net.httpserver.HttpsExchange
com.sun.net.httpserver.HttpsParameters
com.sun.net.httpserver.HttpsServer
This issue is a sub-task of JDK-8252822
Kind regards,
Patrick
Progress
Testing
Failed test task
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/610/head:pull/610
$ git checkout pull/610