Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer #610

Closed
wants to merge 7 commits into from

Conversation

pconcannon
Copy link
Contributor

@pconcannon pconcannon commented Oct 12, 2020

Hi,

Could someone please review my doc-only fix for JDK-8253474: 'Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer' ?

This fix is set of formatting changes intended to clean up the javadoc of the following classes :

com.sun.net.httpserver.HttpsExchange
com.sun.net.httpserver.HttpsParameters
com.sun.net.httpserver.HttpsServer

This issue is a sub-task of JDK-8252822

Kind regards,
Patrick


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) (1/9 failed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/610/head:pull/610
$ git checkout pull/610

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2020

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 12, 2020
@openjdk
Copy link

openjdk bot commented Oct 12, 2020

@pconcannon The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Oct 12, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2020

Webrevs

@dfuch
Copy link
Member

dfuch commented Oct 12, 2020

This is a JDK specific API - but since you're updating (filling out) some API doc comments that were previously empty I suspect a CSR will still be needed.
/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Oct 12, 2020
@openjdk
Copy link

openjdk bot commented Oct 12, 2020

@dfuch has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@pconcannon please create a CSR request and add link to it in JDK-8253474. This pull request cannot be integrated until the CSR request is approved.

dfuch
dfuch approved these changes Oct 19, 2020
dfuch
dfuch approved these changes Oct 19, 2020
@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Oct 21, 2020
@openjdk
Copy link

openjdk bot commented Oct 21, 2020

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253474: Javadoc clean up in HttpsExchange, HttpsParameters, and HttpsServer

Reviewed-by: dfuchs, michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • 6bd05b1: 8255074: sun.nio.fs.WindowsPath::getPathForWin32Calls synchronizes on String object
  • 9e9f5e6: 8017179: [macosx] list1 and list2 vistble item isn't desired
  • 2ee2b4a: 8231454: File lock in Windows on a loaded jar due to a leak in Introspector::getBeanInfo
  • 42a6ead: 8254884: Make sure jvm does not crash with Arm SVE and Vector API
  • e5870cf: 8252133: The java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java fails if metal pipeline is active
  • afc967f: 8254783: jpackage fails on Windows when application name differs from installer name
  • 3ccf487: 8253019: Enhanced JPEG decoding
  • cfb02d4: 8250861: Crash in MinINode::Ideal(PhaseGVN*, bool)
  • 0d35235: 8249927: Specify limits of jdk.serialProxyInterfaceLimit
  • d6cef99: 8245417: Improve certificate chain handling
  • ... and 32 more: https://git.openjdk.java.net/jdk/compare/3f9c8a39201644952c6d07b97695a5a7ef918622...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 21, 2020
@pconcannon
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Oct 21, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2020
@openjdk
Copy link

openjdk bot commented Oct 21, 2020

@pconcannon Since your change was applied there have been 49 commits pushed to the master branch:

  • 7e26404: 8255000: C2: Unify IGVN processing when loop opts are over
  • 27230fa: 8255026: C2: Miscellaneous cleanups in Compile and PhaseIdealLoop code
  • c107178: 8253964: [Graal] UnschedulableGraphTest#test01fails with expected:<4> but was:<3>
  • bd45191: 8255065: Zero: accessor_entry misses the IRIW case
  • 2a06335: 8254785: compiler/graalunit/HotspotTest.java failed with "missing Graal intrinsics for: java/lang/StringLatin1.indexOfChar([BIII)I"
  • 1b7ddeb: 8254976: Re-enable swing jtreg tests which were broken due to samevm mode
  • 2e510e0: 8255043: Incorrectly styled copyright text
  • 6bd05b1: 8255074: sun.nio.fs.WindowsPath::getPathForWin32Calls synchronizes on String object
  • 9e9f5e6: 8017179: [macosx] list1 and list2 vistble item isn't desired
  • 2ee2b4a: 8231454: File lock in Windows on a loaded jar due to a leak in Introspector::getBeanInfo
  • ... and 39 more: https://git.openjdk.java.net/jdk/compare/3f9c8a39201644952c6d07b97695a5a7ef918622...master

Your commit was automatically rebased without conflicts.

Pushed as commit da97ab5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pconcannon pconcannon deleted the JDK-8253474 branch Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
3 participants