Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8275865: Print deoptimization statistics in product builds #6103

Closed
wants to merge 3 commits into from

Conversation

simonis
Copy link
Member

@simonis simonis commented Oct 25, 2021

Deoptimization statistics are already gathered in product builds but for some (probably historical) reasons aren't printed to the VM/Compiler log. These statics can be useful when analyzing the reasons for deoptimization and frequent recompilations.

Because the statistics are already collected anyway, printing them at VM-exit if either -XX:+LogCompilation or -XX:+LogVMOutput are set won't introduce any runtime overhead.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275865: Print deoptimization statistics in product builds

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6103/head:pull/6103
$ git checkout pull/6103

Update a local copy of the PR:
$ git checkout pull/6103
$ git pull https://git.openjdk.java.net/jdk pull/6103/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6103

View PR using the GUI difftool:
$ git pr show -t 6103

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6103.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 25, 2021

👋 Welcome back simonis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

@simonis The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Oct 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 25, 2021

Webrevs

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Oct 26, 2021

I think the compiler folk need to be the ones to assess this change.

/label add hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler label Oct 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

@dholmes-ora
The hotspot-compiler label was successfully added.

src/hotspot/share/runtime/java.cpp Outdated Show resolved Hide resolved
src/hotspot/share/runtime/java.cpp Outdated Show resolved Hide resolved
test/hotspot/jtreg/runtime/logging/DeoptStats.java Outdated Show resolved Hide resolved
test/hotspot/jtreg/runtime/logging/DeoptStats.java Outdated Show resolved Hide resolved
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@simonis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275865: Print deoptimization statistics in product builds

Reviewed-by: thartmann, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

  • 7c996d5: 8269401: Merge "Exceptions" and "Errors" into "Exception Classes"
  • d88b89f: 8276067: ZGC: Remove unused function alloc_high_address_at_most()
  • 593401f: 8276042: Remove unused local variables in java.naming
  • a2f2d8f: 8276057: Update JMH devkit to 1.33
  • 1750a6e: 8276055: ZGC: Defragment address space
  • d9b0138: 8275704: Metaspace::contains() should be threadsafe
  • 9a3e954: 8274879: Replace uses of StringBuffer with StringBuilder within java.base classes
  • e6fa5fa: 8276063: ProblemList gtest dll_address_to_function_and_library_name on macosx-generic
  • 809488b: 8276046: codestrings.validate_vm gtest fails on ppc64, s390
  • 93be099: 4718400: Many quantities are held as signed that should be unsigned
  • ... and 38 more: https://git.openjdk.java.net/jdk/compare/0bcc1749eaea20cb983a983073ad33d305681879...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 28, 2021
@simonis
Copy link
Member Author

@simonis simonis commented Oct 28, 2021

/reviewer credit @vnkozlov

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@simonis
Reviewer kvn successfully credited.

@simonis
Copy link
Member Author

@simonis simonis commented Oct 28, 2021

Thanks for the reviews @TobiHartmann & @vnkozlov !

@simonis
Copy link
Member Author

@simonis simonis commented Oct 28, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

Going to push as commit a343fa8.
Since your change was applied there have been 49 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@simonis Pushed as commit a343fa8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-runtime integrated
4 participants