New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8275865: Print deoptimization statistics in product builds #6103
Conversation
|
Webrevs
|
I think the compiler folk need to be the ones to assess this change. /label add hotspot-compiler |
@dholmes-ora |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@simonis This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 48 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/reviewer credit @vnkozlov |
@simonis |
Thanks for the reviews @TobiHartmann & @vnkozlov ! |
/integrate |
Going to push as commit a343fa8.
Your commit was automatically rebased without conflicts. |
Deoptimization statistics are already gathered in product builds but for some (probably historical) reasons aren't printed to the VM/Compiler log. These statics can be useful when analyzing the reasons for deoptimization and frequent recompilations.
Because the statistics are already collected anyway, printing them at VM-exit if either
-XX:+LogCompilation
or-XX:+LogVMOutput
are set won't introduce any runtime overhead.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6103/head:pull/6103
$ git checkout pull/6103
Update a local copy of the PR:
$ git checkout pull/6103
$ git pull https://git.openjdk.java.net/jdk pull/6103/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6103
View PR using the GUI difftool:
$ git pr show -t 6103
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6103.diff