-
Notifications
You must be signed in to change notification settings - Fork 6k
8275162: Use varargs in 'def' macros in mutexLocker.cpp #6108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
Hi Coleen, So the default for allow_vm_block, if not specified, is false - correct? And you are changing a whole bunch of mutexes from true to false with this change? I'm not clear why some explicit false usages remain. Thanks, |
No, the default for allow_vm_block is 'true' for no-safepoint checking locks and 'false' for safepoint checking locks. I am NOT changing any of the values with this change. Mutex(Rank rank, const char *name) : |
Okay I see. So all the explicit true/false uses are non-default for the given type of Mutex. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine.
Thanks,
David
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks David. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks,
Patricio
Thanks Patricio and David! |
Going to push as commit 71d593e.
Your commit was automatically rebased without conflicts. |
This change uses vararags in the 'def' and 'defl' macros in mutexLocker.cpp so that only the exceptions to the default parameter for _allow_vm_block are specified.
Some of these exceptions are not needed but that's a later patch that I'm working on.
Tested with tier1 sanity (all Oracle platforms) and tier1-3 linux-x64-debug, linux-x64, windows-x64-debug.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6108/head:pull/6108
$ git checkout pull/6108
Update a local copy of the PR:
$ git checkout pull/6108
$ git pull https://git.openjdk.java.net/jdk pull/6108/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6108
View PR using the GUI difftool:
$ git pr show -t 6108
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6108.diff