Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275886: G1: remove obsolete comment in HeapRegion::setup_heap_region_size #6113

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Oct 25, 2021

Trivial change of removing obsolete comment.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275886: G1: remove obsolete comment in HeapRegion::setup_heap_region_size

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6113/head:pull/6113
$ git checkout pull/6113

Update a local copy of the PR:
$ git checkout pull/6113
$ git pull https://git.openjdk.java.net/jdk pull/6113/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6113

View PR using the GUI difftool:
$ git pr show -t 6113

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6113.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 25, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Oct 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 25, 2021

Webrevs

Copy link

@Hamlin-Li Hamlin-Li left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275886: G1: remove obsolete comment in HeapRegion::setup_heap_region_size

Reviewed-by: mli, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 9f75d5c: 8259948: Aarch64: Add cast nodes for Aarch64 Neon backend
  • d98b7c2: 8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails
  • b0d1e4f: 8273585: String.charAt performance degrades due to JDK-8268698
  • 7addcd7: 8276034: ProblemList gtest dll_address_to_function_and_library_name on macosx-x64
  • 2448b3f: 8275874: [JVMCI] only support aligned reads in c2v_readFieldValue
  • f1f5e26: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml
  • 19f76c2: 8275079: Remove unnecessary conversion to String in java.net.http
  • e5cd269: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info
  • 82f4aac: 8259609: C2: optimize long range checks in long counted loops
  • 574f890: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak
  • ... and 22 more: https://git.openjdk.java.net/jdk/compare/1da5e6b0e2c284c5dd295a0d48cc1c6c2fecf5b5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 27, 2021
Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm.

@albertnetymk
Copy link
Member Author

@albertnetymk albertnetymk commented Oct 27, 2021

Thanks for the review.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

Going to push as commit 9e831bc.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 9f75d5c: 8259948: Aarch64: Add cast nodes for Aarch64 Neon backend
  • d98b7c2: 8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails
  • b0d1e4f: 8273585: String.charAt performance degrades due to JDK-8268698
  • 7addcd7: 8276034: ProblemList gtest dll_address_to_function_and_library_name on macosx-x64
  • 2448b3f: 8275874: [JVMCI] only support aligned reads in c2v_readFieldValue
  • f1f5e26: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml
  • 19f76c2: 8275079: Remove unnecessary conversion to String in java.net.http
  • e5cd269: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info
  • 82f4aac: 8259609: C2: optimize long range checks in long counted loops
  • 574f890: 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak
  • ... and 22 more: https://git.openjdk.java.net/jdk/compare/1da5e6b0e2c284c5dd295a0d48cc1c6c2fecf5b5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

@albertnetymk Pushed as commit 9e831bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the comment branch Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants