Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8213120: java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java fails on mac10.13 #6116

Closed
wants to merge 2 commits into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Oct 26, 2021

Looks like this test was failing in one local system in JDK12 and it was problemlisted.
I ran this test multiple times in our CI systems it doesnt fail.
Made modifications to move test window to the middle of the screen and added autodelay for robot. Tested in our CI systems with modifications and test run is green.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8213120: java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java fails on mac10.13

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6116/head:pull/6116
$ git checkout pull/6116

Update a local copy of the PR:
$ git checkout pull/6116
$ git pull https://git.openjdk.java.net/jdk pull/6116/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6116

View PR using the GUI difftool:
$ git pr show -t 6116

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6116.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 26, 2021

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

@jayathirthrao The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Oct 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 26, 2021

Webrevs

Copy link
Contributor

@prsadhuk prsadhuk left a comment

It will be better to dispose frame in finally block. Also, better to use BUTTON1_DOWN_MASK instead of deprecated BUTTON1_MASK

@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Oct 27, 2021

It will be better to dispose frame in finally block. Also, better to use BUTTON1_DOWN_MASK instead of deprecated BUTTON1_MASK

@prsadhuk we explicitly call dispose() if any of test cases fail. So test should not leave unwanted window. I have update test to use BUTTON1_DOWN_MASK

@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8213120: java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java fails on mac10.13

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 9e831bc: 8275886: G1: remove obsolete comment in HeapRegion::setup_heap_region_size
  • 9f75d5c: 8259948: Aarch64: Add cast nodes for Aarch64 Neon backend
  • d98b7c2: 8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails
  • b0d1e4f: 8273585: String.charAt performance degrades due to JDK-8268698
  • 7addcd7: 8276034: ProblemList gtest dll_address_to_function_and_library_name on macosx-x64
  • 2448b3f: 8275874: [JVMCI] only support aligned reads in c2v_readFieldValue
  • f1f5e26: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml
  • 19f76c2: 8275079: Remove unnecessary conversion to String in java.net.http
  • e5cd269: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info
  • 82f4aac: 8259609: C2: optimize long range checks in long counted loops
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/3ff085e2967508ad312c9d32fa908807aefe69ee...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 27, 2021
@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Oct 27, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

Going to push as commit 2f979ec.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 9e831bc: 8275886: G1: remove obsolete comment in HeapRegion::setup_heap_region_size
  • 9f75d5c: 8259948: Aarch64: Add cast nodes for Aarch64 Neon backend
  • d98b7c2: 8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails
  • b0d1e4f: 8273585: String.charAt performance degrades due to JDK-8268698
  • 7addcd7: 8276034: ProblemList gtest dll_address_to_function_and_library_name on macosx-x64
  • 2448b3f: 8275874: [JVMCI] only support aligned reads in c2v_readFieldValue
  • f1f5e26: 8275872: Sync J2DBench run and analyze Makefile targets with build.xml
  • 19f76c2: 8275079: Remove unnecessary conversion to String in java.net.http
  • e5cd269: 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info
  • 82f4aac: 8259609: C2: optimize long range checks in long counted loops
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/3ff085e2967508ad312c9d32fa908807aefe69ee...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 27, 2021
@jayathirthrao jayathirthrao deleted the JDK-8213120 branch Oct 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

@jayathirthrao Pushed as commit 2f979ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated
2 participants