8254370: Update the classes in the java.awt.color package #612

mrserb · 2020-10-12T18:23:48Z

The spec for ICC_ProfileRGB.getGamma(int) and ICC_ProfileRGB.getTRC(int) is updated
Two additional tests are added to cover some basic specified functionality
Some code in these classes was simplified/cleaned
Some common code is extracted to the separate methods.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

JDK-8254370: Update the classes in the java.awt.color package

Reviewers

Phil Race (@prrace - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/612/head:pull/612
$ git checkout pull/612

mrserb · 2020-10-12T18:23:57Z

/csr

bridgekeeper · 2020-10-12T18:24:14Z

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-10-12T18:26:41Z

@mrserb has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@mrserb please create a CSR request and add link to it in JDK-8254608. This pull request cannot be integrated until the CSR request is approved.

openjdk · 2020-10-12T18:28:40Z

@mrserb The following labels will be automatically applied to this pull request:

2d
awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mrserb · 2020-10-12T18:28:59Z

/label remove awt

openjdk · 2020-10-12T18:29:05Z

@mrserb
The awt label was successfully removed.

mlbridge · 2020-10-12T18:35:26Z

Webrevs

00: Full (54792d4)

mrserb · 2020-10-20T16:17:32Z

/csr

openjdk · 2020-10-20T16:18:26Z

@mrserb an approved CSR request is already required for this pull request.

mrserb · 2020-10-20T16:19:18Z

/label remove csr

openjdk · 2020-10-20T16:19:41Z

@mrserb The label csr is not a valid label. These labels are valid:

serviceability
hotspot
sound
hotspot-compiler
kulla
i18n
shenandoah
jdk
javadoc
2d
security
swing
hotspot-runtime
jmx
build
nio
beans
core-libs
compiler
net
hotspot-gc
hotspot-jfr
awt

mrserb · 2020-10-20T16:20:37Z

/csr unneeded

openjdk · 2020-10-20T16:21:30Z

@mrserb determined that a CSR request is not needed for this pull request.

mrserb · 2020-10-20T16:21:45Z

/csr

openjdk · 2020-10-20T16:22:08Z

@mrserb this pull request will not be integrated until the CSR request JDK-8254608 for issue JDK-8254370 has been approved.

prrace · 2020-10-24T23:04:02Z

src/java.desktop/share/classes/java/awt/color/ICC_ProfileGray.java

-    short[]    theTRC;
-
-        theTRC = super.getTRC(ICC_Profile.icSigGrayTRCTag);
-        return theTRC;


hmm this old code looked like it might be trying to avoid its own override but no such override exists ...

prrace · 2020-10-24T23:09:44Z

src/java.desktop/share/classes/java/awt/color/ICC_ProfileRGB.java

+     * @throws IllegalArgumentException if the component is not
+     *         {@code REDCOMPONENT}, {@code GREENCOMPONENT}, or
+     *         {@code BLUECOMPONENT}
     * @throws ProfileDataException if the profile does not specify the


You said no CSR is needed but you document a previously undocumented exception, so I think a CSR is warranted

CSR is needed and linked from the JBS, and after a few attempts, it is referenced from this pull request a few comments above.

Ok. There's a very weird sequence above of it being added, and you removing it and whatever so it is confusing.
I'll find the CSR and review / ok it.

openjdk · 2020-10-26T22:14:36Z

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254370: Update the classes in the java.awt.color package

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 260 new commits pushed to the master branch:

ca8bba6: 8238263: Create at-requires mechanism for containers
a7fa1b7: 8251994: VM crashed running TestComplexAddrExpr.java test with -XX:UseAVX=X
b498433: 8254825: Monitoring available clipboard formats should be done via new Windows APIs
de05b00: 8255365: Problem list failing client manual tests
49c4978: 8060202: [macosx] Test closed/java/awt/Choice/GetSizeTest/GetSizeTest fails only in MacOSX(10.10)
2b47a58: 8028281: [TEST_BUG] [macosx] javax/swing/JTabbedPane/7024235/Test7024235.java fails
83a91bf: 8253734: C2: Optimize Move nodes
6666dcb: 8237363: Remove automatic is in heap verification in OopIterateClosure
fa64477: 8255301: Common and strengthen the code in ciMemberName and ciMethodHandle
9b5a2a6: 8255349: Vector API issues on Big Endian
... and 250 more: https://git.openjdk.java.net/jdk/compare/77c776275e2f3694f020ef9a77b120c913a3a119...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

mrserb · 2020-10-26T23:55:04Z

/integrate

openjdk · 2020-10-26T23:59:36Z

@mrserb Since your change was applied there have been 261 commits pushed to the master branch:

8ca59c9: 8255206: [macos] LicenseTest fails on macOS 11
ca8bba6: 8238263: Create at-requires mechanism for containers
a7fa1b7: 8251994: VM crashed running TestComplexAddrExpr.java test with -XX:UseAVX=X
b498433: 8254825: Monitoring available clipboard formats should be done via new Windows APIs
de05b00: 8255365: Problem list failing client manual tests
49c4978: 8060202: [macosx] Test closed/java/awt/Choice/GetSizeTest/GetSizeTest fails only in MacOSX(10.10)
2b47a58: 8028281: [TEST_BUG] [macosx] javax/swing/JTabbedPane/7024235/Test7024235.java fails
83a91bf: 8253734: C2: Optimize Move nodes
6666dcb: 8237363: Remove automatic is in heap verification in OopIterateClosure
fa64477: 8255301: Common and strengthen the code in ciMemberName and ciMethodHandle
... and 251 more: https://git.openjdk.java.net/jdk/compare/77c776275e2f3694f020ef9a77b120c913a3a119...master

Your commit was automatically rebased without conflicts.

Pushed as commit abdbbe3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

mrserb added 2 commits October 11, 2020 21:59

Initial fix

3f3e8b1

Update ColorSpace.java

54792d4

openjdk bot added the csr Pull request needs approved CSR before integration label Oct 12, 2020

openjdk bot added 2d client-libs-dev@openjdk.org awt client-libs-dev@openjdk.org labels Oct 12, 2020

openjdk bot removed the awt client-libs-dev@openjdk.org label Oct 12, 2020

mrserb marked this pull request as ready for review October 12, 2020 18:30

openjdk bot added the rfr Pull request is ready for review label Oct 12, 2020

mrserb marked this pull request as draft October 14, 2020 00:10

mrserb marked this pull request as ready for review October 14, 2020 00:11

mrserb changed the title ~~8254608: Update the classes in the java.awt.color package~~ 8254370: Update the classes in the java.awt.color package Oct 14, 2020

openjdk bot removed the csr Pull request needs approved CSR before integration label Oct 20, 2020

openjdk bot added the csr Pull request needs approved CSR before integration label Oct 20, 2020

prrace reviewed Oct 24, 2020

View reviewed changes

prrace approved these changes Oct 25, 2020

View reviewed changes

openjdk bot removed the csr Pull request needs approved CSR before integration label Oct 26, 2020

openjdk bot added the ready Pull request is ready to be integrated label Oct 26, 2020

openjdk bot closed this Oct 26, 2020

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 26, 2020

mrserb deleted the JDK-8254370 branch October 26, 2020 23:56

8254370: Update the classes in the java.awt.color package #612

8254370: Update the classes in the java.awt.color package #612

Uh oh!

Conversation

mrserb commented Oct 12, 2020 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Testing

Issue

Reviewers

Download

Uh oh!

mrserb commented Oct 12, 2020

Uh oh!

bridgekeeper bot commented Oct 12, 2020

Uh oh!

openjdk bot commented Oct 12, 2020

Uh oh!

openjdk bot commented Oct 12, 2020

Uh oh!

mrserb commented Oct 12, 2020

Uh oh!

openjdk bot commented Oct 12, 2020

Uh oh!

mlbridge bot commented Oct 12, 2020

Webrevs

Uh oh!

mrserb commented Oct 20, 2020

Uh oh!

openjdk bot commented Oct 20, 2020

Uh oh!

mrserb commented Oct 20, 2020

Uh oh!

openjdk bot commented Oct 20, 2020

Uh oh!

mrserb commented Oct 20, 2020

Uh oh!

openjdk bot commented Oct 20, 2020

Uh oh!

mrserb commented Oct 20, 2020

Uh oh!

openjdk bot commented Oct 20, 2020

Uh oh!

prrace Oct 24, 2020

Choose a reason for hiding this comment

Uh oh!

prrace Oct 24, 2020

Choose a reason for hiding this comment

Uh oh!

mrserb Oct 25, 2020

Choose a reason for hiding this comment

Uh oh!

prrace Oct 25, 2020

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Oct 26, 2020

Uh oh!

mrserb commented Oct 26, 2020

Uh oh!

openjdk bot commented Oct 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

mrserb commented Oct 12, 2020 •

edited by openjdk bot

Loading