Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails #6121

Closed

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Oct 26, 2021

The test is still failing on Ubuntu 16.04 (window1 and window2 are not placed in front, so they are not receiving events).

Looks like this was fixed in later releases. I've manually checked this test on Ubuntu 18.04, 20.04, 21.04 and they are not affected.

We can remove the test from the problem list since we are no longer supporting Ubuntu 16.04.

Automated testing is also green.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6121/head:pull/6121
$ git checkout pull/6121

Update a local copy of the PR:
$ git checkout pull/6121
$ git pull https://git.openjdk.java.net/jdk pull/6121/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6121

View PR using the GUI difftool:
$ git pr show -t 6121

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6121.diff

@azvegint
Copy link
Member Author

@azvegint azvegint commented Oct 26, 2021

/label add client

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 26, 2021

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr client labels Oct 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

@azvegint
The client label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 26, 2021

Webrevs

mrserb
mrserb approved these changes Oct 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2448b3f: 8275874: [JVMCI] only support aligned reads in c2v_readFieldValue

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 26, 2021
@azvegint
Copy link
Member Author

@azvegint azvegint commented Oct 27, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

Going to push as commit d98b7c2.
Since your change was applied there have been 3 commits pushed to the master branch:

  • b0d1e4f: 8273585: String.charAt performance degrades due to JDK-8268698
  • 7addcd7: 8276034: ProblemList gtest dll_address_to_function_and_library_name on macosx-x64
  • 2448b3f: 8275874: [JVMCI] only support aligned reads in c2v_readFieldValue

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

@azvegint Pushed as commit d98b7c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated
2 participants