Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976 #6122

Closed
wants to merge 3 commits into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Oct 26, 2021

Please consider this proposed change to ignore comparing the total size of /dev as returned by DF(1) and STAT(2) on macOS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6122/head:pull/6122
$ git checkout pull/6122

Update a local copy of the PR:
$ git checkout pull/6122
$ git pull https://git.openjdk.java.net/jdk pull/6122/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6122

View PR using the GUI difftool:
$ git pr show -t 6122

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6122.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2021

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@bplb
Copy link
Member Author

bplb commented Oct 26, 2021

Alternative approaches would be to compare File.getTotalSpace() with FileStore.getTotalSpace() and / or have a tolerance on the comparison.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 26, 2021
@openjdk
Copy link

openjdk bot commented Oct 26, 2021

@bplb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 26, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2021

Webrevs

test/jdk/java/io/File/GetXSpace.java Outdated Show resolved Hide resolved
@bplb
Copy link
Member Author

bplb commented Oct 28, 2021

Please refer to the issue for more detail, but this change is proposed because the total size of /dev can in fact change over time on macOS. Given that df and getTotalSpace() derive their values at different points in time, there is no way to guarantee that the two values will be equal.

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

LTGM

(While you're in there you could suppress the compilation warnings about deprecated SM).

@openjdk
Copy link

openjdk bot commented Oct 28, 2021

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976

Reviewed-by: rriggs, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • c6339cb: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle
  • 5a768f7: 8276054: JMH benchmarks for Fences
  • 6d8fa8f: 8255286: Implement ParametersTypeData::print_data_on fully
  • 63b9f8c: 8153490: Cannot setBytes() if incoming buffer's length is bigger than number of elements we want to insert.
  • cb989cf: 8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks
  • c92f230: 8276110: Problemlist javax/swing/JMenu/4515762/bug4515762.java for macos12
  • 309acbf: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem
  • abe52ae: 8275518: accessibility issue in Inet6Address docs
  • 85d8cd8: 8276100: Remove G1SegmentedArray constructor name parameter
  • a343fa8: 8275865: Print deoptimization statistics in product builds
  • ... and 24 more: https://git.openjdk.java.net/jdk/compare/f1f5e2690cb93c07eb8be96a4cbfbf140e8a15e0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 28, 2021
naotoj
naotoj approved these changes Oct 28, 2021
@bplb
Copy link
Member Author

bplb commented Oct 28, 2021

Good idea, @RogerRiggs , will do.

@bplb
Copy link
Member Author

bplb commented Oct 29, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 29, 2021

Going to push as commit 13265f9.
Since your change was applied there have been 49 commits pushed to the master branch:

  • 5facaa2: 8276128: (bf) Remove unused constant ARRAY_BASE_OFFSET from Direct-X-Buffer
  • d6d82f5: 8275608: runtime/Metaspace/elastic/TestMetaspaceAllocationMT2 too slow
  • a1ec4f9: 6854300: [TEST_BUG] java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_3.java fails in jdk6u14 & jdk7
  • 8cc5950: 8251468: X509Certificate.get{Subject,Issuer}AlternativeNames and getExtendedKeyUsage do not throw CertificateParsingException if extension is unparseable
  • 4c3491b: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac
  • c0cda1d: 8273026: Slow LoginContext.login() on multi threading application
  • 15fd8a3: 8276102: JDK-8245095 integration reverted JDK-8247980
  • e89b2c0: 8276086: Increase size of metaspace mappings
  • 24cf480: 8276047: G1: refactor G1CardSetArrayLocker
  • e922023: 8275909: [JVMCI] c2v_readFieldValue use long instead of jlong for the offset parameter
  • ... and 39 more: https://git.openjdk.java.net/jdk/compare/f1f5e2690cb93c07eb8be96a4cbfbf140e8a15e0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2021
@openjdk
Copy link

openjdk bot commented Oct 29, 2021

@bplb Pushed as commit 13265f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the File-GetXSpace-8274750 branch Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants