Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976 #6122

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -203,6 +203,13 @@ private static void tryCatch(Space s) {
}

private static void compare(Space s) {
// On macOS the total size of /dev can vary over time
// so this test is skipped for /dev
if (Platform.isOSX() && s.name().equals("/dev")) {
out.println("/dev:\n Skipping size comparison for /dev on macOS");
return;
bplb marked this conversation as resolved.
Show resolved Hide resolved
}

File f = new File(s.name());
long ts = f.getTotalSpace();
long fs = f.getFreeSpace();
@@ -231,7 +238,6 @@ private static void compare(Space s) {
throw new RuntimeException(e);
}


// On macOS, the number of 1024 byte blocks might be incorrectly
// calculated by 'df' using integer division by 2 of the number of
// 512 byte blocks, resulting in a size smaller than the actual