Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276034: ProblemList gtest dll_address_to_function_and_library_name on macosx-x64 #6125

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Oct 26, 2021

A trivial fix to ProblemList gtest dll_address_to_function_and_library_name on macosx-x64.

Tested locally on my MBP13. Here's the baseline results for running the
dll_address_to_function_and_library_name sub-test:

$ grep -c dll_address_to_function_and_library_name *.baseline.jtr
GTestWrapper.fastdebug.baseline.jtr:2
GTestWrapper.release.baseline.jtr:2
GTestWrapper.slowdebug.baseline.jtr:2
NMTGtests_nmt-detail.fastdebug.baseline.jtr:2
NMTGtests_nmt-detail.slowdebug.baseline.jtr:2
NMTGtests_nmt-summary.fastdebug.baseline.jtr:0
NMTGtests_nmt-summary.slowdebug.baseline.jtr:0

Here's the results for running the dll_address_to_function_and_library_name sub-test
with the fix in place:

$ grep -c dll_address_to_function_and_library_name *.8274388.jtr
GTestWrapper.fastdebug.8274388.jtr:0
GTestWrapper.release.8274388.jtr:0
GTestWrapper.slowdebug.8274388.jtr:0
NMTGtests_nmt-detail.fastdebug.8274388.jtr:0
NMTGtests_nmt-detail.slowdebug.8274388.jtr:0
NMTGtests_nmt-summary.fastdebug.8274388.jtr:0
NMTGtests_nmt-summary.slowdebug.8274388.jtr:0


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276034: ProblemList gtest dll_address_to_function_and_library_name on macosx-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6125/head:pull/6125
$ git checkout pull/6125

Update a local copy of the PR:
$ git checkout pull/6125
$ git pull https://git.openjdk.java.net/jdk pull/6125/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6125

View PR using the GUI difftool:
$ git pr show -t 6125

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6125.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Oct 26, 2021

/label add hotspot-runtime

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Oct 26, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 26, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Oct 26, 2021

@prrace - Here's the new PR...

prrace
prrace approved these changes Oct 26, 2021
@openjdk openjdk bot added the rfr label Oct 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276034: ProblemList gtest dll_address_to_function_and_library_name on macosx-x64

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 26, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Oct 26, 2021

/integrate

@openjdk openjdk bot added the hotspot-runtime label Oct 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Oct 26, 2021

@prrace - Thanks for the lighting fast review!

@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

Going to push as commit 7addcd7.

@openjdk openjdk bot closed this Oct 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

@dcubed-ojdk Pushed as commit 7addcd7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 26, 2021

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8276034 branch Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
2 participants