Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails #6128

Closed
wants to merge 2 commits into from

Conversation

azuev-java
Copy link
Member

@azuev-java azuev-java commented Oct 27, 2021

The problem here is that due to the approximation of the coordinates when converting
to and from screen cordinate system on screen with 125% magnification
two things can happen:

  1. New mouse position calculated can be 149/149 which is the same as the starting position
    and system can refuse to generate new mouse event which causes false positive of the test
    since second mouse motion listener was never called;
  2. Even if event is generated the resulting reported coordinates can differ by 1 pixel
    in any of the directions;

To solve it i moved away the target point to make sure that move event always generated and
comparing expected and actual coordinates with approximation of +/- 1 pixel.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6128/head:pull/6128
$ git checkout pull/6128

Update a local copy of the PR:
$ git checkout pull/6128
$ git pull https://git.openjdk.java.net/jdk pull/6128/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6128

View PR using the GUI difftool:
$ git pr show -t 6128

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6128.diff

…p.java fails

Made a target point further away from the source point
Use +/-1 point approximation to take into account possible rounding error when calculating position on
screens with different magnification factors
Imports cleanup
Removing test from problem list
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2021

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2021
@openjdk
Copy link

openjdk bot commented Oct 27, 2021

@azuev-java The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 27, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2021

Webrevs

@mrserb
Copy link
Member

mrserb commented Oct 29, 2021

I have tried to run this test on macOS as a standalone code, and it hangs. The second frame is never disposed and still visible on the screen, not sure why.

@azuev-java
Copy link
Member Author

azuev-java commented Oct 29, 2021

I have tried to run this test on macOS as a standalone code, and it hangs. The second frame is never disposed and still visible on the screen, not sure why.

Yep, it works fine running from JavaTest but hangs when running from IDE, looks like extra mouseMove event being generated and we create extra frame. Luckily, that's easy to fix.

mrserb
mrserb approved these changes Oct 30, 2021
@openjdk
Copy link

openjdk bot commented Oct 30, 2021

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 93 new commits pushed to the master branch:

  • 5bbc8d3: 8274621: NullPointerException because listenAddress[0] is null
  • 5021a12: 8274855: vectorapi tests failing with assert(!vbox->is_Phi()) failed
  • fe6a202: 8271356: Modify jdb to treat an empty command as a repeat of the previous command
  • cef9db9: 8276039: Remove unnecessary qualifications of java_lang_Class::
  • 13265f9: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976
  • 5facaa2: 8276128: (bf) Remove unused constant ARRAY_BASE_OFFSET from Direct-X-Buffer
  • d6d82f5: 8275608: runtime/Metaspace/elastic/TestMetaspaceAllocationMT2 too slow
  • a1ec4f9: 6854300: [TEST_BUG] java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_3.java fails in jdk6u14 & jdk7
  • 8cc5950: 8251468: X509Certificate.get{Subject,Issuer}AlternativeNames and getExtendedKeyUsage do not throw CertificateParsingException if extension is unparseable
  • 4c3491b: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac
  • ... and 83 more: https://git.openjdk.java.net/jdk/compare/fab3d6c6122b2ce23dfa12db489923d8261f8f35...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 30, 2021
@azuev-java
Copy link
Member Author

azuev-java commented Oct 30, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 30, 2021

Going to push as commit b7104ba.
Since your change was applied there have been 94 commits pushed to the master branch:

  • 6875678: 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned
  • 5bbc8d3: 8274621: NullPointerException because listenAddress[0] is null
  • 5021a12: 8274855: vectorapi tests failing with assert(!vbox->is_Phi()) failed
  • fe6a202: 8271356: Modify jdb to treat an empty command as a repeat of the previous command
  • cef9db9: 8276039: Remove unnecessary qualifications of java_lang_Class::
  • 13265f9: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976
  • 5facaa2: 8276128: (bf) Remove unused constant ARRAY_BASE_OFFSET from Direct-X-Buffer
  • d6d82f5: 8275608: runtime/Metaspace/elastic/TestMetaspaceAllocationMT2 too slow
  • a1ec4f9: 6854300: [TEST_BUG] java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_3.java fails in jdk6u14 & jdk7
  • 8cc5950: 8251468: X509Certificate.get{Subject,Issuer}AlternativeNames and getExtendedKeyUsage do not throw CertificateParsingException if extension is unparseable
  • ... and 84 more: https://git.openjdk.java.net/jdk/compare/fab3d6c6122b2ce23dfa12db489923d8261f8f35...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 30, 2021
@openjdk
Copy link

openjdk bot commented Oct 30, 2021

@azuev-java Pushed as commit b7104ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb
Copy link
Member

mrserb commented Nov 10, 2021

@azuev-java
Looks like this test still fails if the 200% dpi is set on the windows, can you please confirm that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants