8276036: The value of full_count in the message of insufficient codecache is wrong #6129
Conversation
|
Hi @tkiriyama, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user tkiriyama" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
@tkiriyama The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/covered |
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
Hi, please contact me at dalibor.topic@oracle.com so that I can verify your account. |
|
@robilad robilad Thank you for your reply. |
bridgekeeper
bot
removed
oca
| Process javaProcess = pb.start(); | ||
| javaProcess.waitFor(); | ||
|
|
||
| OutputAnalyzer javaOutput = new OutputAnalyzer(javaProcess); | ||
| String stdout = javaOutput.getStdout(); |
There was a problem hiding this comment.
Use ProcessTools.executeProcess(pb) instead:
OutputAnalyzer oa = ProcessTools.executeProcess(pb);
oa.shouldHaveExitValue(0);
String stdout = oa.getStdout();
|
Hi @tkiriyama, this bug was already fixed and integrated by @tobiasholenstein a few days a ago: Since your account was only verified yesterday, an RFR email could not be sent out to the email list to inform people about your fix. Please make sure that you always assign JBS issues to you when you intend to work on them (the issue was assigned to @tobiasholenstein). If you do not have an account, reach out to someone with an account to reserve/sponsor it for you. This avoids duplicated work. Nevertheless, it is nice that you also found a test to verify your fix. I suggest to file a follow-up RFE to add your test for JDK-8276036 separately. Thanks, |
|
Hi, @chhagedorn , thank you for your valuable comments. I will try that. |
|
JDK-8276036 was already fixed. I close this pull request. |
Could you please review the 8276036 bug fixes?
This bug is caused by the wrong place to add the value of full_count.
The initial value of full_count is 0, so it needs to be added before outputting the message.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6129/head:pull/6129$ git checkout pull/6129Update a local copy of the PR:
$ git checkout pull/6129$ git pull https://git.openjdk.java.net/jdk pull/6129/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6129View PR using the GUI difftool:
$ git pr show -t 6129Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6129.diff