Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276036: The value of full_count in the message of insufficient codecache is wrong #6129

Closed
wants to merge 3 commits into from

Conversation

tkiriyama
Copy link
Contributor

@tkiriyama tkiriyama commented Oct 27, 2021

Could you please review the 8276036 bug fixes?

This bug is caused by the wrong place to add the value of full_count.
The initial value of full_count is 0, so it needs to be added before outputting the message.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276036: The value of full_count in the message of insufficient codecache is wrong ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6129/head:pull/6129
$ git checkout pull/6129

Update a local copy of the PR:
$ git checkout pull/6129
$ git pull https://git.openjdk.java.net/jdk pull/6129/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6129

View PR using the GUI difftool:
$ git pr show -t 6129

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6129.diff

@bridgekeeper bridgekeeper bot added the oca label Oct 27, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 27, 2021

Hi @tkiriyama, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user tkiriyama" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

@tkiriyama The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Oct 27, 2021
@tkiriyama
Copy link
Contributor Author

@tkiriyama tkiriyama commented Oct 27, 2021

/covered

@bridgekeeper bridgekeeper bot added the oca-verify label Oct 27, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 27, 2021

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@robilad
Copy link

@robilad robilad commented Oct 27, 2021

Hi, please contact me at dalibor.topic@oracle.com so that I can verify your account.

@tkiriyama
Copy link
Contributor Author

@tkiriyama tkiriyama commented Oct 29, 2021

@robilad robilad Thank you for your reply.
I sent an email to you yesterday. Please check it later.

@bridgekeeper bridgekeeper bot removed oca oca-verify labels Nov 4, 2021
@openjdk openjdk bot added the rfr label Nov 4, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 4, 2021

Webrevs

Process javaProcess = pb.start();
javaProcess.waitFor();

OutputAnalyzer javaOutput = new OutputAnalyzer(javaProcess);
String stdout = javaOutput.getStdout();
Copy link
Member

@chhagedorn chhagedorn Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ProcessTools.executeProcess(pb) instead:

OutputAnalyzer oa = ProcessTools.executeProcess(pb);
oa.shouldHaveExitValue(0);
String stdout = oa.getStdout();

@chhagedorn
Copy link
Member

@chhagedorn chhagedorn commented Nov 5, 2021

Hi @tkiriyama, this bug was already fixed and integrated by @tobiasholenstein a few days a ago:
#6185
61cb4bc

Since your account was only verified yesterday, an RFR email could not be sent out to the email list to inform people about your fix. Please make sure that you always assign JBS issues to you when you intend to work on them (the issue was assigned to @tobiasholenstein). If you do not have an account, reach out to someone with an account to reserve/sponsor it for you. This avoids duplicated work.

Nevertheless, it is nice that you also found a test to verify your fix. I suggest to file a follow-up RFE to add your test for JDK-8276036 separately.

Thanks,
Christian

@tkiriyama
Copy link
Contributor Author

@tkiriyama tkiriyama commented Nov 8, 2021

Hi, @chhagedorn , thank you for your valuable comments. I will try that.

@tkiriyama
Copy link
Contributor Author

@tkiriyama tkiriyama commented Nov 22, 2021

JDK-8276036 was already fixed. I close this pull request.

@tkiriyama tkiriyama closed this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler rfr
3 participants