8276047: G1: refactor G1CardSetArrayLocker

[albertnetymk]

Simple refactoring in G1CardSetArrayLocker:

1. rename fields to sth more explicit
2. drop volatile for thread-local variables
3. increment directly without treating bool as an integer

Test: hotspot_gc

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8276047: G1: refactor G1CardSetArrayLocker

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Stefan Johansson (@kstefanj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6134/head:pull/6134
$ git checkout pull/6134

Update a local copy of the PR:
$ git checkout pull/6134
$ git pull https://git.openjdk.java.net/jdk pull/6134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6134

View PR using the GUI difftool:
$ git pr show -t 6134

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6134.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2ba13342)

[tschatzl]

Lgtm.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276047: G1: refactor G1CardSetArrayLocker

Reviewed-by: tschatzl, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• e922023: 8275909: [JVMCI] c2v_readFieldValue use long instead of jlong for the offset parameter
• 157e1d5: 8275856: Remove MetaspaceHandleDeallocations debug switch
• c9e65f8: 8275440: Remove VirtualSpaceList::is_full()
• de93b1d: 8257722: Improve "keytool -printcert -jarfile" output
• 21da218: 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior
• 48f3fca: 8275308: Add valueOf(Runtime.Version) factory to SourceVersion
• c6339cb: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle
• 5a768f7: 8276054: JMH benchmarks for Fences
• 6d8fa8f: 8255286: Implement ParametersTypeData::print_data_on fully
• 63b9f8c: 8153490: Cannot setBytes() if incoming buffer's length is bigger than number of elements we want to insert.
• ... and 39 more: https://git.openjdk.java.net/jdk/compare/7ca053de218bf76ea06bbeed860d142db381ca53...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kstefanj]

Nice cleanup, looks good!

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 24cf480.
Since your change was applied there have been 49 commits pushed to the master branch:

• e922023: 8275909: [JVMCI] c2v_readFieldValue use long instead of jlong for the offset parameter
• 157e1d5: 8275856: Remove MetaspaceHandleDeallocations debug switch
• c9e65f8: 8275440: Remove VirtualSpaceList::is_full()
• de93b1d: 8257722: Improve "keytool -printcert -jarfile" output
• 21da218: 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior
• 48f3fca: 8275308: Add valueOf(Runtime.Version) factory to SourceVersion
• c6339cb: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle
• 5a768f7: 8276054: JMH benchmarks for Fences
• 6d8fa8f: 8255286: Implement ParametersTypeData::print_data_on fully
• 63b9f8c: 8153490: Cannot setBytes() if incoming buffer's length is bigger than number of elements we want to insert.
• ... and 39 more: https://git.openjdk.java.net/jdk/compare/7ca053de218bf76ea06bbeed860d142db381ca53...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 24cf480.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.